Skip to content

Reduce Vault batch size #1937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cedric-cordenier merged 1 commit into from
Mar 27, 2026
+3 −3
Merged

Reduce Vault batch size #1937

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/settings/cresettings/defaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"VaultIdentifierKeySizeLimit": "64b",
"VaultIdentifierOwnerSizeLimit": "64b",
"VaultIdentifierNamespaceSizeLimit": "64b",
"VaultPluginBatchSizeLimit": "10",
"VaultPluginBatchSizeLimit": "1",
"VaultRequestBatchSizeLimit": "10",
"VaultMaxQuerySizeLimit": "102.4kb",
"VaultMaxObservationSizeLimit": "512kb",
Expand Down
2 changes: 1 addition & 1 deletion pkg/settings/cresettings/defaults.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ VaultShareSizeLimit = '600b'
VaultIdentifierKeySizeLimit = '64b'
VaultIdentifierOwnerSizeLimit = '64b'
VaultIdentifierNamespaceSizeLimit = '64b'
VaultPluginBatchSizeLimit = '10'
VaultPluginBatchSizeLimit = '1'
VaultRequestBatchSizeLimit = '10'
VaultMaxQuerySizeLimit = '102.4kb'
VaultMaxObservationSizeLimit = '512kb'
Expand Down
2 changes: 1 addition & 1 deletion pkg/settings/cresettings/settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ var Default = Schema{
VaultIdentifierKeySizeLimit: Size(64 * config.Byte),
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes a Vault OCR plugin default that the comment above flags as requiring a safe upgrade path (nodes may apply old/new defaults inconsistently during image upgrades). Please ensure deployments override VaultPluginBatchSizeLimit via the on-chain config (or another single source of truth) during rollout, and consider adding a short reference to LINK-777/upgrade notes near this default to prevent accidental unsafe changes later.

Copilot uses AI. Check for mistakes.
VaultIdentifierOwnerSizeLimit: Size(64 * config.Byte),
VaultIdentifierNamespaceSizeLimit: Size(64 * config.Byte),
VaultPluginBatchSizeLimit: Int(10),
VaultPluginBatchSizeLimit: Int(1),
VaultRequestBatchSizeLimit: Int(10),
VaultShareSizeLimit: Size(600 * config.Byte),

Expand Down
Loading