Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ jobs:
id-token: write
contents: read
actions: read
env:
ALLOW_FAILURE: ${{ contains(join(github.event.pull_request.labels.*.name, ' '), 'allow-lint-issues') }}
steps:
- name: Setup tar default options
shell: bash
Expand All @@ -26,8 +28,13 @@ jobs:
go-version-file: go.mod

- name: Run golangci-lint
if: ${{ env.ALLOW_FAILURE != 'true' }}
uses: smartcontractkit/.github/actions/ci-lint-go@bd2ca3d8fa2dc89f98b49b297e9b72c2e3e68cdc # v3.1.0
with:
golangci-lint-version: v2.6.1
only-new-issues: true
working-directory: pkg
go-directory: pkg

- name: Skip golangci-lint (allow-lint-issues)
if: ${{ env.ALLOW_FAILURE == 'true' }}
run: echo "Skipping golangci-lint because PR has the allow-lint-issues label"
4 changes: 4 additions & 0 deletions contracts/GNUmakefile
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,10 @@ wrappers: pnpmdep mockery abigen ## Recompiles solidity contracts and their go w
./scripts/native_solc_compile_all_$(FOUNDRY_PROFILE)
cd ../gethwrappers; go generate ./$(FOUNDRY_PROFILE)

wrappers-release: export metadata=true
.PHONY: wrappers-release
wrappers-release: ## Generate the gethwrappers for release which includes metadata.
make wrappers

# This call generates all gethwrappers for all products. It does so based on the
# assumption that native_solc_compile_all contains sub-calls to each product, and
Expand Down
90 changes: 45 additions & 45 deletions contracts/gas-snapshots/l2ep.gas-snapshot
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
ArbitrumCrossDomainForwarder_AcceptL1Ownership:test_CallableByPendingL1Owner() (gas: 37563)
ArbitrumCrossDomainForwarder_AcceptL1Ownership:test_NotCallableByNonPendingOwners() (gas: 12954)
ArbitrumCrossDomainForwarder_Constructor:test_InitialState() (gas: 22111)
ArbitrumCrossDomainForwarder_Forward:test_Forward() (gas: 47793)
ArbitrumCrossDomainForwarder_Forward:test_ForwardRevert() (gas: 22258)
ArbitrumCrossDomainForwarder_Forward:test_Forward() (gas: 47761)
ArbitrumCrossDomainForwarder_Forward:test_ForwardRevert() (gas: 22090)
ArbitrumCrossDomainForwarder_Forward:test_NotCallableByUnknownAddress() (gas: 16083)
ArbitrumCrossDomainForwarder_TransferL1Ownership:test_CallableByL1Owner() (gas: 41434)
ArbitrumCrossDomainForwarder_TransferL1Ownership:test_CallableByL1OwnerOrZeroAddress() (gas: 19269)
Expand All @@ -11,15 +11,15 @@ ArbitrumCrossDomainForwarder_TransferL1Ownership:test_NotCallableByNonOwners() (
ArbitrumCrossDomainGovernor_AcceptL1Ownership:test_CallableByPendingL1Owner() (gas: 37563)
ArbitrumCrossDomainGovernor_AcceptL1Ownership:test_NotCallableByNonPendingOwners() (gas: 12954)
ArbitrumCrossDomainGovernor_Constructor:test_InitialState() (gas: 22134)
ArbitrumCrossDomainGovernor_Forward:test_CallableByL2Owner() (gas: 49924)
ArbitrumCrossDomainGovernor_Forward:test_Forward() (gas: 47840)
ArbitrumCrossDomainGovernor_Forward:test_ForwardRevert() (gas: 24367)
ArbitrumCrossDomainGovernor_Forward:test_CallableByL2Owner() (gas: 49879)
ArbitrumCrossDomainGovernor_Forward:test_Forward() (gas: 47795)
ArbitrumCrossDomainGovernor_Forward:test_ForwardRevert() (gas: 24199)
ArbitrumCrossDomainGovernor_Forward:test_NotCallableByUnknownAddress() (gas: 18216)
ArbitrumCrossDomainGovernor_ForwardDelegate:test_BubbleUpRevert() (gas: 19437)
ArbitrumCrossDomainGovernor_ForwardDelegate:test_CallableByCrossDomainMessengerAddressOrL1Owner() (gas: 60762)
ArbitrumCrossDomainGovernor_ForwardDelegate:test_CallableByL2Owner() (gas: 62890)
ArbitrumCrossDomainGovernor_ForwardDelegate:test_BubbleUpRevert() (gas: 19272)
ArbitrumCrossDomainGovernor_ForwardDelegate:test_CallableByCrossDomainMessengerAddressOrL1Owner() (gas: 60718)
ArbitrumCrossDomainGovernor_ForwardDelegate:test_CallableByL2Owner() (gas: 62846)
ArbitrumCrossDomainGovernor_ForwardDelegate:test_NotCallableByUnknownAddress() (gas: 18271)
ArbitrumCrossDomainGovernor_ForwardDelegate:test_RevertsBatchWhenOneCallFails() (gas: 64375)
ArbitrumCrossDomainGovernor_ForwardDelegate:test_RevertsBatchWhenOneCallFails() (gas: 63919)
ArbitrumCrossDomainGovernor_TransferL1Ownership:test_CallableByL1Owner() (gas: 41434)
ArbitrumCrossDomainGovernor_TransferL1Ownership:test_CallableByL1OwnerOrZeroAddress() (gas: 19269)
ArbitrumCrossDomainGovernor_TransferL1Ownership:test_NotCallableByL2Owner() (gas: 18644)
Expand Down Expand Up @@ -47,60 +47,60 @@ BaseSequencerUptimeFeed_UpdateStatus:test_updateStatus_UpdateWhen_StatusChangeAn
BaseSequencerUptimeFeed_transferL1Sender:test_transferL1Sender_CorrectlyTransfersL1Sender() (gas: 1479295)
BaseValidator_Constructor:test_Constructor_EmitsWhen_ConstructorIsSuccessfull() (gas: 715556)
BaseValidator_GetAndSetGasLimit:test_GetAndSetGasLimit_CorrectlyHandlesGasLimit() (gas: 20114)
OptimismCrossDomainForwarder_AcceptL1Ownership:test_CallableByPendingL1Owner() (gas: 47106)
OptimismCrossDomainForwarder_AcceptL1Ownership:test_NotCallableByNonPendingOwners() (gas: 22135)
OptimismCrossDomainForwarder_AcceptL1Ownership:test_CallableByPendingL1Owner() (gas: 46952)
OptimismCrossDomainForwarder_AcceptL1Ownership:test_NotCallableByNonPendingOwners() (gas: 22033)
OptimismCrossDomainForwarder_Constructor:test_InitialState() (gas: 21947)
OptimismCrossDomainForwarder_Forward:test_Forward() (gas: 58188)
OptimismCrossDomainForwarder_Forward:test_ForwardRevert() (gas: 32644)
OptimismCrossDomainForwarder_Forward:test_Forward() (gas: 58095)
OptimismCrossDomainForwarder_Forward:test_ForwardRevert() (gas: 32410)
OptimismCrossDomainForwarder_Forward:test_NotCallableByUnknownAddress() (gas: 13895)
OptimismCrossDomainForwarder_TransferL1Ownership:test_CallableByL1Owner() (gas: 48907)
OptimismCrossDomainForwarder_TransferL1Ownership:test_CallableByL1OwnerOrZeroAddress() (gas: 28728)
OptimismCrossDomainForwarder_TransferL1Ownership:test_CallableByL1Owner() (gas: 48811)
OptimismCrossDomainForwarder_TransferL1Ownership:test_CallableByL1OwnerOrZeroAddress() (gas: 28632)
OptimismCrossDomainForwarder_TransferL1Ownership:test_NotCallableByL2Owner() (gas: 16456)
OptimismCrossDomainForwarder_TransferL1Ownership:test_NotCallableByNonOwners() (gas: 11044)
OptimismCrossDomainGovernor_AcceptL1Ownership:test_CallableByPendingL1Owner() (gas: 47106)
OptimismCrossDomainGovernor_AcceptL1Ownership:test_NotCallableByNonPendingOwners() (gas: 22135)
OptimismCrossDomainGovernor_AcceptL1Ownership:test_CallableByPendingL1Owner() (gas: 46952)
OptimismCrossDomainGovernor_AcceptL1Ownership:test_NotCallableByNonPendingOwners() (gas: 22033)
OptimismCrossDomainGovernor_Constructor:test_InitialState() (gas: 21970)
OptimismCrossDomainGovernor_Forward:test_CallableByL2Owner() (gas: 47768)
OptimismCrossDomainGovernor_Forward:test_Forward() (gas: 58255)
OptimismCrossDomainGovernor_Forward:test_ForwardRevert() (gas: 32668)
OptimismCrossDomainGovernor_Forward:test_CallableByL2Owner() (gas: 47723)
OptimismCrossDomainGovernor_Forward:test_Forward() (gas: 58149)
OptimismCrossDomainGovernor_Forward:test_ForwardRevert() (gas: 32434)
OptimismCrossDomainGovernor_Forward:test_NotCallableByUnknownAddress() (gas: 16031)
OptimismCrossDomainGovernor_ForwardDelegate:test_BubbleUpRevert() (gas: 29227)
OptimismCrossDomainGovernor_ForwardDelegate:test_CallableByCrossDomainMessengerAddressOrL1Owner() (gas: 72811)
OptimismCrossDomainGovernor_ForwardDelegate:test_CallableByL2Owner() (gas: 72816)
OptimismCrossDomainGovernor_ForwardDelegate:test_BubbleUpRevert() (gas: 28984)
OptimismCrossDomainGovernor_ForwardDelegate:test_CallableByCrossDomainMessengerAddressOrL1Owner() (gas: 72772)
OptimismCrossDomainGovernor_ForwardDelegate:test_CallableByL2Owner() (gas: 72777)
OptimismCrossDomainGovernor_ForwardDelegate:test_NotCallableByUnknownAddress() (gas: 16086)
OptimismCrossDomainGovernor_ForwardDelegate:test_RevertsBatchWhenOneCallFails() (gas: 76144)
OptimismCrossDomainGovernor_TransferL1Ownership:test_CallableByL1Owner() (gas: 48907)
OptimismCrossDomainGovernor_TransferL1Ownership:test_CallableByL1OwnerOrZeroAddress() (gas: 28728)
OptimismCrossDomainGovernor_ForwardDelegate:test_RevertsBatchWhenOneCallFails() (gas: 75679)
OptimismCrossDomainGovernor_TransferL1Ownership:test_CallableByL1Owner() (gas: 48811)
OptimismCrossDomainGovernor_TransferL1Ownership:test_CallableByL1OwnerOrZeroAddress() (gas: 28632)
OptimismCrossDomainGovernor_TransferL1Ownership:test_NotCallableByL2Owner() (gas: 16456)
OptimismCrossDomainGovernor_TransferL1Ownership:test_NotCallableByNonOwners() (gas: 11044)
OptimismSequencerUptimeFeed_Constructor:test_Constructor_InitialState() (gas: 1530881)
OptimismSequencerUptimeFeed_ValidateSender:test_ValidateSender_UpdateStatusWhen_StatusChangeAndNoTimeChange() (gas: 15374)
OptimismValidator_Validate:test_Validate_PostSequencerOffline() (gas: 79034)
OptimismValidator_Validate:test_Validate_PostSequencerStatus_NoStatusChange() (gas: 79040)
ScrollCrossDomainForwarder_AcceptL1Ownership:test_CallableByPendingL1Owner() (gas: 47192)
ScrollCrossDomainForwarder_AcceptL1Ownership:test_NotCallableByNonPendingOwners() (gas: 22185)
ScrollCrossDomainForwarder_Constructor:test_InitialState() (gas: 21623)
ScrollCrossDomainForwarder_Forward:test_Forward() (gas: 58252)
ScrollCrossDomainForwarder_Forward:test_ForwardRevert() (gas: 32700)
ScrollCrossDomainForwarder_AcceptL1Ownership:test_CallableByPendingL1Owner() (gas: 47039)
ScrollCrossDomainForwarder_AcceptL1Ownership:test_NotCallableByNonPendingOwners() (gas: 22083)
ScrollCrossDomainForwarder_Constructor:test_InitialState() (gas: 21939)
ScrollCrossDomainForwarder_Forward:test_Forward() (gas: 58159)
ScrollCrossDomainForwarder_Forward:test_ForwardRevert() (gas: 32466)
ScrollCrossDomainForwarder_Forward:test_NotCallableByUnknownAddress() (gas: 13895)
ScrollCrossDomainForwarder_TransferL1Ownership:test_CallableByL1Owner() (gas: 48970)
ScrollCrossDomainForwarder_TransferL1Ownership:test_CallableByL1OwnerOrZeroAddress() (gas: 28786)
ScrollCrossDomainForwarder_TransferL1Ownership:test_CallableByL1Owner() (gas: 48874)
ScrollCrossDomainForwarder_TransferL1Ownership:test_CallableByL1OwnerOrZeroAddress() (gas: 28690)
ScrollCrossDomainForwarder_TransferL1Ownership:test_NotCallableByL2Owner() (gas: 16456)
ScrollCrossDomainForwarder_TransferL1Ownership:test_NotCallableByNonOwners() (gas: 11044)
ScrollCrossDomainGovernor_AcceptL1Ownership:test_CallableByPendingL1Owner() (gas: 47192)
ScrollCrossDomainGovernor_AcceptL1Ownership:test_NotCallableByNonPendingOwners() (gas: 22185)
ScrollCrossDomainGovernor_Constructor:test_InitialState() (gas: 21646)
ScrollCrossDomainGovernor_Forward:test_CallableByL2Owner() (gas: 47763)
ScrollCrossDomainGovernor_Forward:test_Forward() (gas: 58314)
ScrollCrossDomainGovernor_Forward:test_ForwardRevert() (gas: 32721)
ScrollCrossDomainGovernor_AcceptL1Ownership:test_CallableByPendingL1Owner() (gas: 47039)
ScrollCrossDomainGovernor_AcceptL1Ownership:test_NotCallableByNonPendingOwners() (gas: 22083)
ScrollCrossDomainGovernor_Constructor:test_InitialState() (gas: 21962)
ScrollCrossDomainGovernor_Forward:test_CallableByL2Owner() (gas: 47718)
ScrollCrossDomainGovernor_Forward:test_Forward() (gas: 58208)
ScrollCrossDomainGovernor_Forward:test_ForwardRevert() (gas: 32487)
ScrollCrossDomainGovernor_Forward:test_NotCallableByUnknownAddress() (gas: 16028)
ScrollCrossDomainGovernor_ForwardDelegate:test_BubbleUpRevert() (gas: 29285)
ScrollCrossDomainGovernor_ForwardDelegate:test_CallableByCrossDomainMessengerAddressOrL1Owner() (gas: 72875)
ScrollCrossDomainGovernor_ForwardDelegate:test_CallableByL2Owner() (gas: 72880)
ScrollCrossDomainGovernor_ForwardDelegate:test_BubbleUpRevert() (gas: 29042)
ScrollCrossDomainGovernor_ForwardDelegate:test_CallableByCrossDomainMessengerAddressOrL1Owner() (gas: 72836)
ScrollCrossDomainGovernor_ForwardDelegate:test_CallableByL2Owner() (gas: 72841)
ScrollCrossDomainGovernor_ForwardDelegate:test_NotCallableByUnknownAddress() (gas: 16083)
ScrollCrossDomainGovernor_ForwardDelegate:test_RevertsBatchWhenOneCallFails() (gas: 76209)
ScrollCrossDomainGovernor_TransferL1Ownership:test_CallableByL1Owner() (gas: 48970)
ScrollCrossDomainGovernor_TransferL1Ownership:test_CallableByL1OwnerOrZeroAddress() (gas: 28786)
ScrollCrossDomainGovernor_ForwardDelegate:test_RevertsBatchWhenOneCallFails() (gas: 75744)
ScrollCrossDomainGovernor_TransferL1Ownership:test_CallableByL1Owner() (gas: 48874)
ScrollCrossDomainGovernor_TransferL1Ownership:test_CallableByL1OwnerOrZeroAddress() (gas: 28690)
ScrollCrossDomainGovernor_TransferL1Ownership:test_NotCallableByL2Owner() (gas: 16456)
ScrollCrossDomainGovernor_TransferL1Ownership:test_NotCallableByNonOwners() (gas: 11044)
ScrollSequencerUptimeFeed_Constructor:test_Constructor_InitialState_WhenValidL2XDomainMessenger() (gas: 1511902)
Expand Down
2 changes: 1 addition & 1 deletion contracts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,11 @@
"dependencies": {
"@arbitrum/nitro-contracts": "3.0.0",
"@eth-optimism/contracts": "0.6.0",
"@openzeppelin/contracts-4.7.3": "npm:@openzeppelin/contracts@4.7.3",
"@openzeppelin/contracts-4.8.3": "npm:@openzeppelin/contracts@4.8.3",
"@openzeppelin/contracts-4.9.6": "npm:@openzeppelin/contracts@4.9.6",
"@openzeppelin/contracts-5.0.2": "npm:@openzeppelin/contracts@5.0.2",
"@openzeppelin/contracts-5.1.0": "npm:@openzeppelin/contracts@5.1.0",
"@openzeppelin/contracts-5.3.0": "npm:@openzeppelin/contracts@5.3.0",
"@openzeppelin/contracts-upgradeable": "4.9.6",
"@scroll-tech/contracts": "2.0.0",
"@zksync/contracts": "github:matter-labs/era-contracts#446d391d34bdb48255d5f8fef8a8248925fc98b9"
Expand Down
Loading
Loading