Skip to content

beholder: publish workflows/v2/workflow_user_metric#333

Open
karen-stepanyan wants to merge 2 commits intomainfrom
beholder-publish-workflow-user-metrics
Open

beholder: publish workflows/v2/workflow_user_metric#333
karen-stepanyan wants to merge 2 commits intomainfrom
beholder-publish-workflow-user-metrics

Conversation

@karen-stepanyan
Copy link
Copy Markdown
Contributor

@karen-stepanyan karen-stepanyan commented Mar 27, 2026

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 27, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: b08d1d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026 •
edited
Loading

The latest Buf updates on your PR. Results from workflow Regenerate Protobuf Files / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed⏩ skippedMar 27, 2026, 5:23 PM

@karen-stepanyan karen-stepanyan marked this pull request as ready for review March 27, 2026 14:38
@karen-stepanyan karen-stepanyan requested review from a team as code owners March 27, 2026 14:38
hendoxc
hendoxc reviewed Mar 27, 2026
View reviewed changes
Copy link
Copy Markdown

@hendoxc hendoxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only need entry in chip-cre.json

workflows/iron-flask-cre.yaml Outdated
Comment on lines +230 to +238
- entity: WorkflowUserMetric
schema: "workflows/v2/workflow_user_metric.proto"
references:
- name: "workflows/v2/cre_info.proto"
subject: "beholder__cre__messages-workflows.v2.CreInfo"
version: 1
- name: "workflows/v2/workflow_key.proto"
subject: "beholder__cre__messages-workflows.v2.WorkflowKey"
version: 1
Copy link
Copy Markdown

@hendoxc hendoxc Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is deprecated, can remove this entry

workflows/iron-flask-platform.yaml Outdated
subject: "beholder__platform__messages-workflows.v2.WorkflowKey"
version: 1

- entity: WorkflowUserMetric
Copy link
Copy Markdown

@hendoxc hendoxc Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

workflows/chip-platform.json Outdated
}
]
},
{
Copy link
Copy Markdown

@hendoxc hendoxc Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thie entry isn't needed either the platform domain is deprecated

@karen-stepanyan karen-stepanyan requested a review from hendoxc March 27, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gustavogama-cll gustavogama-cll Awaiting requested review from gustavogama-cll

@vyzaldysanchez vyzaldysanchez Awaiting requested review from vyzaldysanchez

@hendoxc hendoxc Awaiting requested review from hendoxc

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@karen-stepanyan @hendoxc