Skip to content

Move ensureSchema to start#350

Merged
pedrovsg merged 3 commits intodevelopfrom
ensureschema
Mar 17, 2026
Merged

Move ensureSchema to start#350
pedrovsg merged 3 commits intodevelopfrom
ensureschema

Conversation

@pedrovsg
Copy link
Copy Markdown
Contributor

No description provided.

ticker := time.NewTicker(eIndexer.pollingInterval)
defer ticker.Stop()

if err := eIndexer.db.EnsureSchema(ctx); err != nil {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: move above the ticker?

ticker := time.NewTicker(eIndexer.pollingInterval)
defer ticker.Stop()

if err := eIndexer.db.EnsureSchema(ctx); err != nil {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a 60s timeout to this context?

@pedrovsg pedrovsg marked this pull request as ready for review March 16, 2026 16:27
@pedrovsg pedrovsg requested a review from a team as a code owner March 16, 2026 16:27
@pedrovsg pedrovsg merged commit 3bbd3ac into develop Mar 17, 2026
37 of 38 checks passed
@pedrovsg pedrovsg deleted the ensureschema branch March 17, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants