vault: add instrumentation and parallelize observation blob broadcasts#21737
Merged
prashantkumar1982 merged 13 commits intodevelopfrom Mar 27, 2026
Merged
vault: add instrumentation and parallelize observation blob broadcasts#21737prashantkumar1982 merged 13 commits intodevelopfrom
prashantkumar1982 merged 13 commits intodevelopfrom
Conversation
Contributor
|
👋 prashantkumar1982, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
|
I see you updated files related to
|
Contributor
|
✅ No conflicts with other open PRs targeting |
Instrument all public KVStore methods with a histogram metric (platform_vault_plugin_kv_operation_duration_seconds) to help diagnose high P95 Observation latencies in production. Also adds a max-batch Observation test exercising 10 GetSecrets requests with 10 encryption keys each plus 20 pending queue items.
prashantkumar1982
changed the title
bolekk
previously approved these changes
Mar 27, 2026
HashWrangler
previously approved these changes
Mar 27, 2026
prashantkumar1982
dismissed stale reviews from HashWrangler and bolekk
via
6fa1e91
|
bolekk
approved these changes
Mar 27, 2026
cedric-cordenier
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR now carries the same Vault change set as the release backport, but targeted at
develop.#21755