Skip to content

vault: validate encrypted value size in request validator#21758

Merged
prashantkumar1982 merged 1 commit intorelease/2.38.1from
codex/vault-encrypted-value-size-validation-2.38.1
Mar 27, 2026
Merged

vault: validate encrypted value size in request validator#21758
prashantkumar1982 merged 1 commit intorelease/2.38.1from
codex/vault-encrypted-value-size-validation-2.38.1

Conversation

@prashantkumar1982
Copy link
Copy Markdown
Contributor

Summary

  • enforce VaultCiphertextSizeLimit in the Vault request validator for create/update requests
  • reject oversized EncryptedValue payloads before label verification
  • add validator unit tests covering boundary and oversized ciphertext cases

Testing

  • go test ./core/capabilities/vault ./core/services/gateway/handlers/vault

@github-actions
Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting release/2.38.1

@github-actions
Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@prashantkumar1982 prashantkumar1982 enabled auto-merge (squash) March 27, 2026 20:58
@prashantkumar1982 prashantkumar1982 added the build-publish Build and Publish image to SDLC label Mar 27, 2026
@trunk-io
Copy link
Copy Markdown

trunk-io bot commented Mar 27, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
Test_CRE_V2_HTTP_Regression/[v2]_HTTP_Trigger_fails_with_invalid_AuthorizedKey.PublicKey_format The test failed due to an invalid public key format in the HTTP trigger workflow. Logs ↗︎
Test_CRE_V2_HTTP_Regression The test named Test_CRE_V2_HTTP_Regression failed during execution. Logs ↗︎

View Full Report ↗︎Docs

@cl-sonarqube-production
Copy link
Copy Markdown

@prashantkumar1982 prashantkumar1982 merged commit ece6c67 into release/2.38.1 Mar 27, 2026
298 of 344 checks passed
@prashantkumar1982 prashantkumar1982 deleted the codex/vault-encrypted-value-size-validation-2.38.1 branch March 27, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build-publish Build and Publish image to SDLC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants