Skip to content

chore: allow configuring fastcgi_pass through environment variable #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XSmeets merged 3 commits into from
Apr 7, 2026
Merged

chore: allow configuring fastcgi_pass through environment variable #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d8a5b1
chore: allow configuring fastcgi_pass through environment variable
XSmeets Apr 7, 2026
669c5c9
fix: envsubst syntax
XSmeets Apr 7, 2026
b25b28c
fix: substitute FASTCGI_PASS as well
XSmeets Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
ARG PHP_VERSION
FROM php:${PHP_VERSION}-cli-alpine AS builder

Check warning on line 2 in Dockerfile

View workflow job for this annotation

GitHub Actions / docker (linux/amd64)

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG php:${PHP_VERSION}-cli-alpine results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 2 in Dockerfile

View workflow job for this annotation

GitHub Actions / docker (linux/amd64)

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG php:${PHP_VERSION}-cli-alpine results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 2 in Dockerfile

View workflow job for this annotation

GitHub Actions / docker (linux/amd64)

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG php:${PHP_VERSION}-cli-alpine results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 2 in Dockerfile

View workflow job for this annotation

GitHub Actions / docker (linux/arm64)

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG php:${PHP_VERSION}-cli-alpine results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 2 in Dockerfile

View workflow job for this annotation

GitHub Actions / docker (linux/arm64)

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG php:${PHP_VERSION}-cli-alpine results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 2 in Dockerfile

View workflow job for this annotation

GitHub Actions / docker (linux/arm64)

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG php:${PHP_VERSION}-cli-alpine results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/
COPY --from=composer/composer:latest-bin /composer /usr/bin/composer
RUN apk add --no-cache jq icu-dev libldap openldap-dev samba-dev gmp-dev
RUN docker-php-ext-install intl ldap gmp bcmath
Expand All @@ -11,7 +11,7 @@
mv composer.tmp.json composer.json
RUN composer require 'simplesamlphp/simplesamlphp-module-openidprovider:dev-master'

FROM php:${PHP_VERSION}-fpm-alpine AS phpfpm

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / docker (linux/amd64)

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG php:${PHP_VERSION}-fpm-alpine results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / docker (linux/amd64)

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG php:${PHP_VERSION}-fpm-alpine results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / docker (linux/amd64)

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG php:${PHP_VERSION}-fpm-alpine results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / docker (linux/arm64)

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG php:${PHP_VERSION}-fpm-alpine results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / docker (linux/arm64)

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG php:${PHP_VERSION}-fpm-alpine results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 14 in Dockerfile

View workflow job for this annotation

GitHub Actions / docker (linux/arm64)

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG php:${PHP_VERSION}-fpm-alpine results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/
RUN apk add --no-cache icu-dev libldap openldap-dev samba-dev gmp-dev
RUN docker-php-ext-install intl ldap gmp bcmath
COPY --from=builder /var/www/html /var/www/html
Expand All @@ -20,7 +20,8 @@
FROM nginx:alpine AS nginx
COPY nginx.conf.template /nginx.conf.template
COPY --from=builder /var/www/html /var/www/html
CMD ["/bin/sh" , "-c" , "envsubst '${SERVER_NAME}' < /nginx.conf.template > /etc/nginx/nginx.conf && exec nginx -g 'daemon off;'"]
ENV FASTCGI_PASS=phpfpm:9000
CMD ["/bin/sh" , "-c" , "envsubst '${SERVER_NAME} ${FASTCGI_PASS}' < /nginx.conf.template > /etc/nginx/nginx.conf && exec nginx -g 'daemon off;'"]
EXPOSE 8080

FROM phpfpm AS php-adfsmfa
Expand Down
2 changes: 1 addition & 1 deletion nginx.conf.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ http {
alias /var/www/html/public;

location ~ \.php(/|$) {
fastcgi_pass phpfpm:9000;
fastcgi_pass ${FASTCGI_PASS};
fastcgi_index index.php;
Comment thread
XSmeets marked this conversation as resolved.
fastcgi_param SCRIPT_FILENAME $request_filename;
fastcgi_split_path_info ^(.+?\.php)(/.*)$;
Expand Down
Loading