Skip to content

Remove useExternalTypes since its not used anywhere #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adwsingh merged 1 commit into from
Mar 31, 2026
+0 −15
Merged

Remove useExternalTypes since its not used anywhere #1119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions ...n/codegen-core/src/main/java/software/amazon/smithy/java/codegen/JavaCodegenSettings.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ public final class JavaCodegenSettings {
private static final String RELATIVE_DATE = "relativeDate";
private static final String RELATIVE_VERSION = "relativeVersion";
private static final String EDITION = "edition";
private static final String USE_EXTERNAL_TYPES = "useExternalTypes";
private static final String RUNTIME_TRAITS = "runtimeTraits";
private static final String RUNTIME_TRAITS_SELECTOR = "runtimeTraitsSelector";
private static final String MODES = "modes";
Expand All @@ -65,7 +64,6 @@ public final class JavaCodegenSettings {
RELATIVE_DATE,
RELATIVE_VERSION,
EDITION,
USE_EXTERNAL_TYPES,
RUNTIME_TRAITS,
RUNTIME_TRAITS_SELECTOR,
MODES);
Expand All @@ -83,7 +81,6 @@ public final class JavaCodegenSettings {
private final String relativeDate;
private final String relativeVersion;
private final SmithyJavaCodegenEdition edition;
private final boolean useExternalTypes;
private final List<ShapeId> runtimeTraits;
private final Selector runtimeTraitsSelector;
private final ObjectNode httpConfig;
Expand All @@ -103,7 +100,6 @@ private JavaCodegenSettings(Builder builder) {
this.relativeDate = builder.relativeDate;
this.relativeVersion = builder.relativeVersion;
this.edition = Objects.requireNonNullElse(builder.edition, SmithyJavaCodegenEdition.LATEST);
this.useExternalTypes = builder.useExternalTypes;
this.runtimeTraits = Collections.unmodifiableList(builder.runtimeTraits);
this.runtimeTraitsSelector = builder.runtimeTraitsSelector;
this.httpConfig = builder.httpConfig;
Expand All @@ -130,7 +126,6 @@ public static JavaCodegenSettings fromNode(ObjectNode settingsNode) {
.getStringMember(RELATIVE_DATE, builder::relativeDate)
.getStringMember(RELATIVE_VERSION, builder::relativeVersion)
.getStringMember(EDITION, builder::edition)
.getBooleanMember(USE_EXTERNAL_TYPES, builder::useExternalTypes)
.getArrayMember(RUNTIME_TRAITS, n -> n.expectStringNode().expectShapeId(), builder::runtimeTraits)
.getStringMember(RUNTIME_TRAITS_SELECTOR, builder::runtimeTraitsSelector)
.getObjectMember(HTTP_CONFIG, builder::httpConfig);
Expand Down Expand Up @@ -196,10 +191,6 @@ public SmithyJavaCodegenEdition edition() {
return edition;
}

public boolean useExternalTypes() {
return useExternalTypes;
}

public List<ShapeId> runtimeTraits() {
return runtimeTraits;
}
Expand Down Expand Up @@ -256,7 +247,6 @@ public static final class Builder {
private SmithyJavaCodegenEdition edition;
private final List<ShapeId> runtimeTraits = new ArrayList<>();
private Selector runtimeTraitsSelector;
private boolean useExternalTypes;
private ObjectNode httpConfig;

public Builder service(String string) {
Expand Down Expand Up @@ -347,11 +337,6 @@ public Builder edition(String string) {
return this;
}

public Builder useExternalTypes(boolean useExternalTypes) {
this.useExternalTypes = useExternalTypes;
return this;
}

public Builder runtimeTraits(List<ShapeId> runtimeTraits) {
this.runtimeTraits.addAll(runtimeTraits);
return this;
Expand Down
Loading