Conversation
The builders just delegated to the mutable request/response anyway and added unnecessary overhead. Mutable messages are now fluent, have chaining methods like toModifiable and toUnmodifiable, so it obviates the need for builders entirely.
mtdowling
force-pushed
the
remove-message-builders
branch
from
d9a8a1b to
fbbb18f
Compare
kstich
reviewed
Apr 1, 2026
...nt-http/src/main/java/software/amazon/smithy/java/client/http/auth/HttpBearerAuthSigner.java
Outdated
Show resolved
Hide resolved
...t-http/src/main/java/software/amazon/smithy/java/client/http/plugins/HttpChecksumPlugin.java
Outdated
Show resolved
Hide resolved
.../src/main/java/software/amazon/smithy/java/client/http/plugins/RequestCompressionPlugin.java
Outdated
Show resolved
Hide resolved
...ent-http/src/main/java/software/amazon/smithy/java/client/http/auth/HttpBasicAuthSigner.java
Outdated
Show resolved
Hide resolved
...nt-awsjson/src/main/java/software/amazon/smithy/java/aws/client/awsjson/AwsJsonProtocol.java
Outdated
Show resolved
Hide resolved
...ent-rpcv2-cbor/src/main/java/software/amazon/smithy/java/client/rpcv2/RpcV2CborProtocol.java
Show resolved
Hide resolved
mcp/mcp-server/src/main/java/software/amazon/smithy/java/mcp/server/HttpMcpProxy.java
Outdated
Show resolved
Hide resolved
...igv4/src/main/java/software/amazon/smithy/java/aws/client/auth/scheme/sigv4/SigV4Signer.java
Outdated
Show resolved
Hide resolved
...igv4/src/main/java/software/amazon/smithy/java/aws/client/auth/scheme/sigv4/SigV4Signer.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove request/response builders
The builders just delegated to the mutable request/response anyway and added unnecessary overhead. Mutable messages are now fluent, have chaining methods like toModifiable and toUnmodifiable, so it obviates the need for builders entirely.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.