Skip to content

Conversation

@bakpaul
Copy link
Contributor

@bakpaul bakpaul commented May 21, 2024

Add a FixedWeakConstraint. It is really a simplified version of RestShapeSpringForcefield that only fixes points with respect to their rest_shape given one single value of stiffness. I didn't use an inheritance because RestShapeSpringForcefield does too much and the two set of features aren't really compatible. Keep it simple...

This completes the holy trinity of fixed constraints, now we will have Weak, Projective and Langrangian fixed constraints. It unifies the mechanism.

[ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/492]
[ci-depends-on https://github.com/SofaDefrost/SoftRobots/pull/312]
[ci-depends-on https://github.com/SofaDefrost/STLIB/pull/127]
[ci-depends-on https://github.com/sofa-framework/BeamAdapter/pull/160]
[ci-depends-on https://github.com/SofaDefrost/Cosserat/pull/148]
[ci-depends-on https://github.com/SofaDefrost/ModelOrderReduction/pull/146]
[ci-depends-on https://github.com/SofaDefrost/SoftRobots.Inverse/pull/47]
[ci-depends-on https://github.com/SofaDefrost/SoftRobots.DesignOptimization/pull/3]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@bakpaul bakpaul added pr: status to review To notify reviewers to review this pull-request pr: new feature Implement a new feature pr: highlighted in next release Highlight this contribution in the notes of the upcoming release labels May 21, 2024
@bakpaul bakpaul added this to the v24.06 milestone May 21, 2024
@bakpaul bakpaul requested a review from hugtalbot May 21, 2024 15:36
@hugtalbot
Copy link
Contributor

A duplicate of code ?

Copy link
Contributor

@fredroy fredroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical description with RestShapeFF ? 👮

@bakpaul bakpaul modified the milestones: v24.06, v24.12 May 27, 2024
@bakpaul bakpaul added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Jun 5, 2024
@sofa-framework sofa-framework deleted a comment from sofabot Feb 28, 2025
@sofa-framework sofa-framework deleted a comment from sofabot Feb 28, 2025
@sofa-framework sofa-framework deleted a comment from sofabot Feb 28, 2025
@sofa-framework sofa-framework deleted a comment from sofabot Feb 28, 2025
@sofa-framework sofa-framework deleted a comment from sofabot Feb 28, 2025
@sofa-framework sofa-framework deleted a comment from sofabot Mar 4, 2025
@sofa-framework sofa-framework deleted a comment from sofabot Mar 4, 2025
@sofa-framework sofa-framework deleted a comment from sofabot Mar 4, 2025
@sofa-framework sofa-framework deleted a comment from sofabot Apr 3, 2025
@sofa-framework sofa-framework deleted a comment from sofabot Apr 3, 2025
@sofa-framework sofa-framework deleted a comment from sofabot Apr 3, 2025
@sofa-framework sofa-framework deleted a comment from sofabot Apr 3, 2025
@bakpaul
Copy link
Contributor Author

bakpaul commented Apr 3, 2025

[ci-build][with-all-tests]

@sofa-framework sofa-framework deleted a comment from sofabot Apr 3, 2025
@sofa-framework sofa-framework deleted a comment from sofabot Apr 3, 2025
@sofabot
Copy link
Collaborator

sofabot commented Apr 3, 2025

[ci-depends-on] detected during build #36.

To unlock the merge button, you must

@sofabot
Copy link
Collaborator

sofabot commented Apr 3, 2025

[ci-depends-on] detected during build #37.

To unlock the merge button, you must

@hugtalbot
Copy link
Contributor

ci-depends-on ...

@hugtalbot hugtalbot modified the milestones: v25.06, v25.12 May 5, 2025
@hugtalbot hugtalbot removed this from the v25.12 milestone Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: breaking Change possibly inducing a compilation error pr: highlighted in next release Highlight this contribution in the notes of the upcoming release pr: new feature Implement a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants