Skip to content

[Framework] Apply template method design pattern to BaseForceField #5485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hugtalbot wants to merge 16 commits into
base: master
Choose a base branch
from
Open

[Framework] Apply template method design pattern to BaseForceField #5485

hugtalbot wants to merge 16 commits into from

Conversation

@hugtalbot
Copy link
Contributor

@hugtalbot hugtalbot commented May 15, 2025 •
edited
Loading

Based on #5446

Functions

  • addForce
  • addDForce
  • addKToMatrix
  • addBToMatrix
  • buildStiffnessMatrix
  • buildDampingMatrix
  • getPotentialEnergy

[ci-depends-on https://github.com/sofa-framework/SofaSphFluid/pull/16]
[ci-depends-on https://github.com/sofa-framework/Registration/pull/27]
[ci-depends-on https://github.com/SofaDefrost/ModelOrderReduction/pull/162]
[ci-depends-on https://github.com/sofa-framework/BeamAdapter/pull/194]
[ci-depends-on https://github.com/SofaDefrost/SoftRobots/pull/330]
[ci-depends-on https://github.com/sofa-framework/SofaPython3/pull/500]

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added pr: breaking Change possibly inducing a compilation error pr: status wip Development in the pull-request is still in progress refactoring Refactor code labels May 15, 2025
@bakpaul bakpaul added the pr: based on previous PR PR based on a previous PR, therefore to be merged ONLY subsequently label May 15, 2025
hugtalbot and others added 7 commits May 15, 2025 15:39
@hugtalbot
Fix compilation for SOFA, TODO: plugins
e7557fe
@alxbilger @hugtalbot
[Engine.Select] Automatically find topology in MeshBoundaryROI (sofa-…
59f8466 
…framework#5116)

* [Engine.Select] Automatically find topology in MeshBoundaryROI

* add warning when no topology is provided
@alxbilger @hugtalbot
[Core] Rename BaseConstraint to BaseLagrangianConstraint (sofa-framew…
e2e5f6a 
…ork#5423)

* [Core] Rename BaseConstraint to BaseLagrangianConstraint

* restore toBaseConstraint and deprecate it

* fix?

---------

Co-authored-by: Hugo <hugo.talbot@sofa-framework.org>
@hugtalbot
Move all functions in BaseMass.cpp and add comment message
799f7c2
@hugtalbot
Fix compilation CUDA
0e38542
@hugtalbot
fix CUDA compilation on doGetElementMass
62e691d
@hugtalbot
Apply changes on SofaDistanceGrid
b9da001
This was referenced May 27, 2025
Open
Open
Open
Open
Open
@hugtalbot hugtalbot added the pr: highlighted in next release Highlight this contribution in the notes of the upcoming release label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr: based on previous PR PR based on a previous PR, therefore to be merged ONLY subsequently pr: breaking Change possibly inducing a compilation error pr: highlighted in next release Highlight this contribution in the notes of the upcoming release pr: status wip Development in the pull-request is still in progress refactoring Refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hugtalbot @bakpaul @alxbilger