Refactor routing core, introduce route collection and route finder to reduce router responsibilities#415
Merged
armanist merged 13 commits intosoftberg:masterfrom Feb 7, 2026
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
andrey-smaelov
requested changes
Feb 4, 2026
Collaborator
andrey-smaelov
left a comment
There was a problem hiding this comment.
- There are several temp files were pushed (probably by accident) need to be removed
- There are several new error messages that appears all over the code, while need to be placed into
ExceptionMessagesclass
tests/_root/shared/emails/4VT1sZywBYGFCnZarnxm7jWt3bbWkTJNw3lk3inlw.eml
Outdated
Show resolved
Hide resolved
… moving error strings into their class
andrey-smaelov
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Routing Refactor (Breaking Change)
Summary
This PR introduces a breaking refactor of the routing system as part of the 3.0.0 stabilization work.
The focus is correctness, explicit behavior, and test coverage — not redesign.
What changed (high-impact)
RouteRouteCollectionMatchedRouteRouteBuilderRouteDispatcherMatchedRoutestored onRequestcurrent_*,route_*) now read fromMatchedRouteContributors should focus review effort on the following areas:
1. Controller resolution
RouteController-based resolution is no longer used2. RouteBuilder behavior
3. Request → routing boundary
MatchedRouteis nullableWhat this PR does not do
How to review
Suggested review order:
RouteBuilderand its unit testsRouteDispatcherThis refactor affects core request flow — careful review is appreciated.
Closes #412