feat: Run shadow and color CSS transitions on Core Animation#9656
Open
MatiPl01 wants to merge 1 commit into
Open
feat: Run shadow and color CSS transitions on Core Animation#9656MatiPl01 wants to merge 1 commit into
MatiPl01 wants to merge 1 commit into
Conversation
MatiPl01
force-pushed
the
@matipl01/css-platform-shadow-color-props
branch
from
d418cd8 to
9118a15
Compare
MatiPl01
force-pushed
the
@matipl01/css-platform-routing-eligibility
branch
2 times, most recently
from
fc9dfc8 to
47a4295
Compare
MatiPl01
force-pushed
the
@matipl01/css-platform-shadow-color-props
branch
from
9118a15 to
3c385cc
Compare
MatiPl01
force-pushed
the
@matipl01/css-platform-routing-eligibility
branch
from
47a4295 to
7964685
Compare
MatiPl01
force-pushed
the
@matipl01/css-platform-shadow-color-props
branch
from
3c385cc to
5a1dcdf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #9655.
Adds
shadowOpacity,shadowRadius,shadowOffset,shadowColor,backgroundColorandborderColorto the set of CSS transition properties that run on Core Animation (behindIOS_CSS_CORE_ANIMATION).Shadow properties always live on the view's main layer. Background and border colors route only while RN uses Core Animation border rendering for the view (mirrored
useCoreAnimationBorderRenderingcondition) - otherwise RN draws them into sublayers that are rebuilt on every commit, so such views keep using the loop.Test plan
-fsyntax-onlycompile check, clang-format cleanIOS_CSS_CORE_ANIMATIONflag enabled