fix(worklets): Keep getTransformOptions arguments in metro for bundle mode#9658
Open
Warabi1915181 wants to merge 2 commits into
Open
fix(worklets): Keep getTransformOptions arguments in metro for bundle mode#9658Warabi1915181 wants to merge 2 commits into
Warabi1915181 wants to merge 2 commits into
Conversation
Warabi1915181
changed the title
Warabi1915181
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The metro documentation states that the
getTransformOptionsfunction has three parameters. For compatibility reasons, the originalgetBundleModeMetroConfigin this library would try to rungetTransformOptionsfrom upstream metro configs. However, the parameters are not being passed to the function, causing unintended compatibility issues.Test plan
This PR only touches the metro config for
react-native-workletsbundle mode. The test plan would be bundling a react native project while enabling thereact-native-workletsbundle mode.