MPT-19892: add E2E tests for Extension base service - Includes renaming from extensibility -> integrations#277
Merged
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (23)
💤 Files with no reviewable changes (2)
✅ Files skipped from review due to trivial changes (5)
🚧 Files skipped from review as they are similar to previous changes (8)
📝 WalkthroughWalkthroughThe PR renames the Extensibility API surface to Integration across the client and resource packages, updates API endpoints from Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~30 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
albertsola
force-pushed
the
MPT-19892/e2e-extension-base-service
branch
from
d911034 to
0e44cd6
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/e2e/extensibility/extensions/conftest.py`:
- Around line 37-40: The teardown currently swallows all MPTAPIError exceptions
when calling extensions_service.delete(extension.id); update the except block to
check error.status (not error.status_code) and only suppress the exception if
error.status == 404 (resource already deleted); for any other status re-raise
the exception so real cleanup failures are not masked, and keep the diagnostic
print/log mentioning extension.id and the error for the suppressed 404 case.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: c4bbd156-85b2-49da-98eb-7a7eb1333520
📒 Files selected for processing (6)
e2e_config.test.jsontests/e2e/extensibility/__init__.pytests/e2e/extensibility/extensions/__init__.pytests/e2e/extensibility/extensions/conftest.pytests/e2e/extensibility/extensions/test_async_extensions.pytests/e2e/extensibility/extensions/test_sync_extensions.py
✅ Files skipped from review due to trivial changes (1)
- e2e_config.test.json
🚧 Files skipped from review as they are similar to previous changes (2)
- tests/e2e/extensibility/extensions/test_sync_extensions.py
- tests/e2e/extensibility/extensions/test_async_extensions.py
albertsola
force-pushed
the
MPT-19892/e2e-extension-base-service
branch
from
0e44cd6 to
5c7c216
Compare
albertsola
force-pushed
the
MPT-19892/e2e-extension-base-service
branch
from
5c7c216 to
ac93e5e
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
tests/unit/test_mpt_client.py (1)
43-44: Consider adding compatibility assertions for legacy client attributeIf backward compatibility is intended, add regression coverage for
.extensibility(deprecated alias) so this doesn’t regress silently in later changes.Also applies to: 76-77
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/unit/test_mpt_client.py` around lines 43 - 44, Add regression assertions that the deprecated alias .extensibility still maps to the same object as the new attribute for Integration in tests: after instantiating or collecting the ("integration", Integration) case, assert that instance.extensibility is present and equal (is or == depending on intended semantics) to the current attribute (e.g., instance.extensibility is instance.extensible_attribute_or_name); repeat the same assertion for the other occurrence referenced around lines 76-77 so the legacy alias cannot regress silently.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@mpt_api_client/mpt_client.py`:
- Around line 96-99: Add a backward-compatible deprecated alias for the renamed
property by adding an extensibility property that returns the same
AsyncIntegration instance as integration but emits a DeprecationWarning;
specifically, keep the existing integration(self) -> AsyncIntegration method
unchanged and implement a new extensibility(self) -> AsyncIntegration that
calls/returns AsyncIntegration(http_client=self.http_client) (or reuses
self.integration()) and uses the warnings module to warn users about the rename
to integration; apply the same pattern for the other duplicate location where
the alias was removed (the second integration/extensibility occurrence).
In `@mpt_api_client/resources/integration/integration.py`:
- Around line 8-9: The rename from Extensibility/AsyncExtensibility to
Integration/AsyncIntegration breaks existing imports; restore backwards
compatibility by adding compatibility aliases: keep the new classes Integration
and AsyncIntegration as-is and define Extensibility = Integration and
AsyncExtensibility = AsyncIntegration (and emit a DeprecationWarning in their
__init__ or module import path) so downstream code can still import the old
names while signaling deprecation; update the module docstring or comments to
note the alias and planned removal.
---
Nitpick comments:
In `@tests/unit/test_mpt_client.py`:
- Around line 43-44: Add regression assertions that the deprecated alias
.extensibility still maps to the same object as the new attribute for
Integration in tests: after instantiating or collecting the ("integration",
Integration) case, assert that instance.extensibility is present and equal (is
or == depending on intended semantics) to the current attribute (e.g.,
instance.extensibility is instance.extensible_attribute_or_name); repeat the
same assertion for the other occurrence referenced around lines 76-77 so the
legacy alias cannot regress silently.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 512bc115-d865-44a1-8cbf-7d77e87e1a46
📒 Files selected for processing (23)
e2e_config.test.jsonmpt_api_client/mpt_client.pympt_api_client/resources/__init__.pympt_api_client/resources/extensibility/__init__.pympt_api_client/resources/integration/__init__.pympt_api_client/resources/integration/extensions.pympt_api_client/resources/integration/integration.pympt_api_client/resources/integration/mixins/__init__.pympt_api_client/resources/integration/mixins/extension_mixin.pypyproject.tomltests/e2e/integration/__init__.pytests/e2e/integration/extensions/__init__.pytests/e2e/integration/extensions/conftest.pytests/e2e/integration/extensions/test_async_extensions.pytests/e2e/integration/extensions/test_sync_extensions.pytests/unit/resources/extensibility/test_extensibility.pytests/unit/resources/integration/__init__.pytests/unit/resources/integration/conftest.pytests/unit/resources/integration/mixins/__init__.pytests/unit/resources/integration/mixins/test_extension_mixin.pytests/unit/resources/integration/test_extensions.pytests/unit/resources/integration/test_integration.pytests/unit/test_mpt_client.py
💤 Files with no reviewable changes (2)
- tests/unit/resources/extensibility/test_extensibility.py
- mpt_api_client/resources/extensibility/init.py
✅ Files skipped from review due to trivial changes (1)
- mpt_api_client/resources/integration/mixins/init.py
🚧 Files skipped from review as they are similar to previous changes (1)
- e2e_config.test.json
albertsola
changed the title
- Add sync and async E2E tests for /public/v1/extensibility/extensions - Tests cover: create, get, not_found, update, delete, filter, download_icon, publish, unpublish - Add extensibility.extension.id placeholder to e2e_config.test.json Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
albertsola
force-pushed
the
MPT-19892/e2e-extension-base-service
branch
from
ac93e5e to
f3f16bc
Compare
|
This was referenced Apr 7, 2026
jentyk
approved these changes
Apr 7, 2026
d3rky
added a commit
that referenced
this pull request
May 8, 2026
## Summary Implements the `/public/v1/integration/installations` endpoint group as part of MPT-13310. ### Changes - `mpt_api_client/resources/integration/installations.py` — `InstallationsService` / `AsyncInstallationsService` - `mpt_api_client/resources/integration/mixins/installation_mixin.py` — lifecycle actions: invite, install, uninstall, expire - Updated `integration.py` to expose `installations` property - Unit tests: `tests/unit/resources/integration/test_installations.py` + `test_installation_mixin.py` - E2e tests: `tests/e2e/integration/installations/` ### Depends on #277 (MPT-19892 — rename extensibility → integration) >⚠️ **Draft** — targets `MPT-19892/e2e-extension-base-service` until PR #277 merges. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> Closes [MPT-19908](https://softwareone.atlassian.net/browse/MPT-19908) - Add InstallationsService and AsyncInstallationsService for /public/v1/integration/installations - Introduce Installation model (id, name, revision, account, extension, status, configuration, invitation, modules, terms, audit) - Add InstallationMixin and AsyncInstallationMixin exposing redeem lifecycle action - Expose installations property on Integration and AsyncIntegration - Add unit tests for installations service, installation mixin, and Integration/AsyncIntegration properties - Add e2e tests and fixtures for installations (sync and async) covering create/get/filter/redeem/delete flows - Add helper for decoding invitation payloads used by e2e tests - Update e2e_config.test.json: set integration.extension.id = EXT-6587-4477 and add integration.installation.id = EXI-0022-3978-5547 - Update e2e fixtures to source extension clients from mpt_vendor and unskip several extension e2e tests (create/update/delete/download_icon) - Update pyproject.toml flake8 per-file-ignores for new e2e installation tests - Draft PR depends on PR #277 (MPT-19892 — rename extensibility → integration); currently targets MPT-19892/e2e-extension-base-service until merged <!-- end of auto-generated comment: release notes by coderabbit.ai --> [MPT-19908]: https://softwareone.atlassian.net/browse/MPT-19908?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
d3rky
added a commit
that referenced
this pull request
May 11, 2026
## Summary
Implements the
`/public/v1/integration/extensions/{extensionId}/instances` endpoint
group as part of MPT-13310.
### Changes
- `mpt_api_client/resources/integration/extension_instances.py` —
CreateMixin + GetMixin + CollectionMixin
- Updated `extensions.py` to expose `instances(extension_id)` accessor
- Unit tests:
`tests/unit/resources/integration/test_extension_instances.py`
- E2e tests: `tests/e2e/integration/extension_instances/`
### Depends on
#277 (MPT-19892 — rename extensibility → integration)
> ⚠️ **Draft** — targets `MPT-19892/e2e-extension-base-service` until PR
#277 merges.
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
Closes [MPT-19903](https://softwareone.atlassian.net/browse/MPT-19903)
- Implements the
`/public/v1/integration/extensions/{extensionId}/instances` endpoint
group
- Adds `ExtensionInstance` model with attributes for identity,
relationships, and state
- Introduces `ExtensionInstancesService` and
`AsyncExtensionInstancesService` with create, get, and list operations
- Exposes `instances(extension_id)` accessor methods on both synchronous
and asynchronous extensions services
- Adds unit tests covering service mixins, model field mapping, and
accessor methods
- Adds end-to-end integration tests for both sync and async workflows
(create, filter, and get operations)
- Updates e2e configuration with extension instance identifier mapping
[](https://app.coderabbit.ai/change-stack/softwareone-platform/mpt-api-python-client/pull/283)
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
[MPT-19903]:
https://softwareone.atlassian.net/browse/MPT-19903?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
](https://app.coderabbit.ai/change-stack/softwareone-platform/mpt-api-python-client/pull/283){kind=link}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds E2E tests for the Extension base service (
/public/v1/extensibility/extensions).Changes
New files
tests/e2e/extensibility/extensions/conftest.py— fixtures:extensions_service,async_extensions_service,extension_id,extension_data,created_extension(with icon upload + auto-cleanup), async variantstests/e2e/extensibility/extensions/test_sync_extensions.pytests/e2e/extensibility/extensions/test_async_extensions.pyModified
e2e_config.test.json— addextensibility.extension.idplaceholder (update with real ID before running)Tests (sync + async)
test_create_extensiontest_get_extensiontest_get_extension_not_foundMPTAPIError404test_update_extensiontest_delete_extensiontest_filter_extensionstest_download_iconFileModeltest_publish_extensionPublictest_unpublish_extensionPrivateCloses MPT-19892