e2e: add locators, env tweaks and stability logs#414
Merged
Conversation
Various e2e test improvements and stability fixes: - recommendations: added savings/table locators and no-recommendations locator; updated mocks to include table savings and placeholder modalColumnLocator; added debug logging in getCurrencyValue. - auth.setup: improved wait logic for initialization message using LARGE_DATA_TIMEOUT, added debug/error logging and a short presence check to avoid hanging. - tests: made several tests environment-aware (use env to pick regions/tags/data sources), added conditional skips when no recommendations or low numeric values, and added additional debug logs to reduce flakiness. - policies & tagging-policy tests: replaced hardcoded region/tag values with env-based choices and updated assertions accordingly. These changes aim to make tests more robust across environments, handle cases with no or zero recommendations, and improve observability when waiting for slow/large-data initializations.
Remove a leftover inline comment after the debugLog call in RecommendationsPage.getCurrencyValue. This is a non-functional cleanup to tidy the code and avoid unnecessary noise in the source.
dwolosz
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Various e2e test improvements and stability fixes:
These changes aim to make tests more robust across environments, handle cases with no or zero recommendations, and improve observability when waiting for slow/large-data initializations.
Related issue number
https://softwareone.atlassian.net/browse/MPT-20927