enable JFR metrics by default #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables JFR (Java Flight Recorder) metrics by default to populate the runtime dashboard with telemetry data. The change configures the OpenTelemetry runtime-telemetry-java17 instrumentation to enable all available runtime metrics.
Key changes:
- Enables all JFR metrics via the
runtime-telemetry-java17instrumentation configuration - Adds test coverage to verify JVM 17+ runtime metrics are exported correctly
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
custom/src/main/java/com/solarwinds/opentelemetry/extensions/SolarwindsPropertiesSupplier.java |
Adds configuration property to enable all runtime telemetry metrics for Java 17+ |
smoke-tests/sdk-config.yaml |
Enables runtime telemetry in the smoke test SDK configuration |
smoke-tests/k6/basic.js |
Adds verification check for jvm.network.time metric export |
smoke-tests/src/test/java/com/solarwinds/SmokeTest.java |
Adds test assertion for JVM 17+ runtime metrics |
smoke-tests/src/test/java/com/solarwinds/SmokeTestV2.java |
Adds test assertion for JVM 17+ runtime metrics |
custom/src/main/java/com/solarwinds/opentelemetry/extensions/SolarwindsPropertiesSupplier.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Enabling JFR metrics by default so that runtime dashboard is not empty.
Test Plan:
added tests
Test services data