remove JDK v1.8.252 requirement #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the JDK version 1.8.252 minimum requirement that previously prevented the agent from initializing on older Java 8 patch versions. The agent now allows execution on any Java 8 or higher runtime, with profiling features conditionally disabled for versions below 1.8.252.
Key Changes:
- Removed JDK version check from agent initialization logic
- Added conditional profiling activation based on JDK version
- Updated warning messages to clarify profiling-specific version requirements
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| AutoConfigurationCustomizerProviderImpl.java | Removed version check that disabled entire agent; replaced with profiling-specific warning |
| DeclarativeLoader.java | Removed agent disablement logic; kept profiling version warning |
| SolarwindsTracerProviderCustomizer.java | Added conditional profiling span processor registration based on JDK version |
| CustomConfigCustomizerProvider.java | Added JDK version check before adding profiling processor |
| SolarwindsAgentListener.java | Added JDK version check before profiler initialization; removed system monitor code |
| AutoConfigurationCustomizerProviderImplTest.java | Added teardown to reset static agentEnabled field between tests |
| CustomConfigCustomizerProviderTest.java | Added tests verifying profiling processor conditional registration |
| SolarwindsTracerProviderCustomizerTest.java | New test file verifying profiling span processor conditional behavior |
...rwinds/opentelemetry/extensions/config/provider/AutoConfigurationCustomizerProviderImpl.java
Show resolved
Hide resolved
custom/src/main/java/com/solarwinds/opentelemetry/extensions/config/DeclarativeLoader.java
Show resolved
Hide resolved
cheempz
approved these changes
Jan 6, 2026
Contributor
cheempz
left a comment
cheempz
left a comment
There was a problem hiding this comment.
LGTM, thanks @cleverchuk esp. for the pre 252 patch adhoc test link!
| } | ||
| }.buildMonitors()); | ||
| logger.debug("Started System monitor"); | ||
|
|
Contributor
There was a problem hiding this comment.
Above is no longer needed AO-style metrics code, correct?
Contributor
Author
There was a problem hiding this comment.
mainly tace.jvm.* metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This PR removes the previous restriction that required users to run the SolarWinds APM Java agent on JDK version 1.8.252 or higher. Previously, the agent would fail to initialize on older Java 8 patch versions due to the
JavaRuntimeVersionCheckervalidation. This validation is removed and users can now run the agent on any Java 8 or higher runtime without encountering initialization failures due to patch version restrictions with the caveat thatProfilingis permanently disabled for versions before1.8.252Test Plan:
Regression plus additional test and manually on JDK
1.8.242Test services data