Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/chilly-birds-write.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
41 changes: 41 additions & 0 deletions packages/components/src/components/dropdown/dropdown.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -461,4 +461,45 @@ describe('<sd-dropdown>', () => {
// expect(el.open).to.be.false;
// expect(hideHandler).to.not.have.been.called;
// });

it('should open and close correctly when nested in a double shadow root (regression #648)', async () => {
// Declarative shadow DOM isn't processed by innerHTML/lit-html, so attach shadow roots imperatively
const outerHost = await fixture<HTMLDivElement>(html`<div></div>`);
const outerShadow = outerHost.attachShadow({ mode: 'open' });

const innerHost = document.createElement('div');
outerShadow.appendChild(innerHost);
const innerShadow = innerHost.attachShadow({ mode: 'open' });

innerShadow.innerHTML = `
<sd-dropdown>
<sd-button slot="trigger" caret>Toggle</sd-button>
<sd-menu>
<sd-menu-item>Item 1</sd-menu-item>
<sd-menu-item>Item 2</sd-menu-item>
<sd-menu-item>Item 3</sd-menu-item>
</sd-menu>
</sd-dropdown>
`;

const el = innerShadow.querySelector<SdDropdown>('sd-dropdown')!;
await el.updateComplete;
const panel = el.shadowRoot!.querySelector<HTMLElement>('[part~="panel"]')!;

// Wait for the component to fully settle after innerHTML upgrade
await waitUntil(() => panel.hidden);

const afterShowHandler = sinon.spy();
const afterHideHandler = sinon.spy();
el.addEventListener('sd-after-show', afterShowHandler);
el.addEventListener('sd-after-hide', afterHideHandler);

el.show();
await waitUntil(() => afterShowHandler.calledOnce);
expect(panel.hidden).to.be.false;

el.hide();
await waitUntil(() => afterHideHandler.calledOnce);
expect(panel.hidden).to.be.true;
});
});
Loading