Skip to content

fix: sd-datepicker css properties not showing in storybook#3058

Open
martascorreia wants to merge 4 commits into
mainfrom
fix/missing-ccs-properties
Open

fix: sd-datepicker css properties not showing in storybook#3058
martascorreia wants to merge 4 commits into
mainfrom
fix/missing-ccs-properties

Conversation

@martascorreia

Copy link
Copy Markdown
Contributor

Description:

closes: #3053

The issue is that the JSDoc comments (@summary, @dependency, @dependency, @cssproperty, etc) are the documentation for the @CustomElement, and therefore have to be immediately before this element.

For the fix, I could've moved the converter classes to before the JSDocs, but for readability and maintainability, I created a new file. Let me know if this is the best approach or if you rather have them at the top. They have to be put before the @CustomElement, otherwise it can't read them.

Definition of Reviewable:

  • Documentation is created/updated
  • Migration Guide is created/updated
  • E2E tests (features, a11y, bug fixes) are created/updated
  • Stories (features, a11y) are created/updated
  • relevant tickets are linked

@changeset-bot

changeset-bot Bot commented May 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 03da8ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@solid-design-system/components Patch
@solid-design-system/styles Patch
@solid-design-system/tokens Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@martascorreia martascorreia moved this from 📋 Backlog to 🏗 In progress in Solid Design System Project Board May 29, 2026
@martascorreia martascorreia moved this from 🏗 In progress to 👀 In review in Solid Design System Project Board May 29, 2026
@martascorreia martascorreia changed the title fix: fixed css properties not showing in storybook fix: sd-datepicker css properties not showing in storybook May 29, 2026
@github-actions

github-actions Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

🚀 Storybook has been deployed for branch fix_missing-ccs-properties

@tega-ekakitie

Copy link
Copy Markdown

Hi @martascorreia for sd-datepicker, this is fine now but I checked all the components and noticed there is no css property for the following components, let me know if they're not supposed to have;

  • sd-carousel-item
  • sd-checkbox-group
  • sd-icon
  • sd-loader
  • sd-menu

Also for the sd-expandable, this error is being returned importing a module script failed. See screenshot
Screenshot 2026-06-01 at 08 45 35

@martascorreia

Copy link
Copy Markdown
Contributor Author

Hi @martascorreia for sd-datepicker, this is fine now but I checked all the components and noticed there is no css property for the following components, let me know if they're not supposed to have;

* sd-carousel-item

* sd-checkbox-group

* sd-icon

* sd-loader

* sd-menu

Also for the sd-expandable, this error is being returned importing a module script failed. See screenshot Screenshot 2026-06-01 at 08 45 35

Hey @tega-ekakitie,
Not all components have currently css properties, only the ones we define figma token variables for. So in this case, the sd-carousel-item, sd-carousel-item, sd-icon, sd-loader and the sd-menu don't have them.
Example of sd-badge, that has css properties:
image

Example of sd-checkbox-group, that doesn't have any css properties:
image

As for the sd-expandable issue, could you check again, I can't seem to reproduce it. Does it appear as soon as you enter the "Docs" page?

@tega-ekakitie

Copy link
Copy Markdown

@martascorreia looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

fix: sd-datepicker css properties not showing in docs

6 participants