Skip to content

fix: sd-teaser-media focus ring contrast #3063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balco0110 merged 2 commits into from
Jun 2, 2026
+16 −6
Merged

fix: sd-teaser-media focus ring contrast #3063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b75666
fix: sd-teaser-media focus ring contrast
balco0110 Jun 1, 2026
e696b86
chore: fixed the datepicker test
balco0110 Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/violet-cooks-dream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@solid-design-system/components': patch
---

Fixed the focus ring on the `sd-teaser-media` expandable toggle so it is clearly visible across all variants
11 changes: 5 additions & 6 deletions packages/components/src/components/datepicker/datepicker.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import '../../../dist/solid-components';
import { clickOnElement } from '../../internal/test.js';
import { expect, fixture, html, waitUntil } from '@open-wc/testing';
import { sendKeys } from '@web/test-runner-commands';
import sinon from 'sinon';
Expand Down Expand Up @@ -176,9 +175,9 @@ describe('<sd-datepicker>', () => {
await el.updateComplete;

const dayButtons = el.shadowRoot!.querySelectorAll('button.day:not(.out-month):not(.disabled)');
await clickOnElement(dayButtons[5]);
(dayButtons[5] as HTMLButtonElement).click();
await el.updateComplete;
await clickOnElement(dayButtons[10]);
(dayButtons[10] as HTMLButtonElement).click();
await el.updateComplete;

expect(el.rangeStart).to.not.be.null;
Expand All @@ -195,7 +194,7 @@ describe('<sd-datepicker>', () => {
await el.updateComplete;

const dayButtons = el.shadowRoot!.querySelectorAll('button.day:not(.out-month):not(.disabled)');
await clickOnElement(dayButtons[5]);
(dayButtons[5] as HTMLButtonElement).click();
await el.updateComplete;

expect(rangeSelectHandler).to.have.been.calledOnce;
Expand All @@ -208,9 +207,9 @@ describe('<sd-datepicker>', () => {
await el.updateComplete;

const dayButtons = el.shadowRoot!.querySelectorAll('button.day:not(.out-month):not(.disabled)');
await clickOnElement(dayButtons[10]);
(dayButtons[10] as HTMLButtonElement).click();
await el.updateComplete;
await clickOnElement(dayButtons[5]);
(dayButtons[5] as HTMLButtonElement).click();
await el.updateComplete;

expect(el.rangeStart).to.not.be.null;
Expand Down
6 changes: 6 additions & 0 deletions packages/components/src/components/teaser-media/teaser-media.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,12 @@ export default class SdTeaserMedia extends SolidElement {

[part='toggle'] {
@apply w-fit;
@apply outline-transparent;
}

:host([variant='primary']) [part='toggle']:focus-visible,
:host([variant='gradient-dark']) [part='toggle']:focus-visible {
outline-color: rgba(var(--sd-color-text-white));
}
`
];
Expand Down
Loading