Skip to content

feat: added footer to the templates#3064

Open
rahulsuvarna18 wants to merge 3 commits into
mainfrom
feat/template-links-components
Open

feat: added footer to the templates#3064
rahulsuvarna18 wants to merge 3 commits into
mainfrom
feat/template-links-components

Conversation

@rahulsuvarna18

Copy link
Copy Markdown
Contributor

closes #1554

Description:

Definition of Reviewable:

  • relevant tickets are linked

@changeset-bot

changeset-bot Bot commented Jun 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 27d7cf0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@solid-design-system/docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rahulsuvarna18 rahulsuvarna18 moved this from 📋 Backlog to 👀 In review in Solid Design System Project Board Jun 1, 2026
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Storybook has been deployed for branch feat_template-links-components

@rahulsuvarna18 rahulsuvarna18 changed the title Added footer to the templates page feat: added footer to the templates page Jun 1, 2026
@rahulsuvarna18 rahulsuvarna18 changed the title feat: added footer to the templates page feat: added footer to the templates Jun 2, 2026

@MartaPintoTeixeira MartaPintoTeixeira left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you align the copy of the footer with the elements above?
In this case it should go more to the left so the headline is aligned with the headline above.

also please check responsive. it is not behaving properly in smaller screens

also when clicking on "Icon" under Audio it leads to an error FYI

@rahulsuvarna18

Copy link
Copy Markdown
Contributor Author

FYI: I see a weird behavior on this PR. The footer on my local environment is at the bottom and loads properly. But the footer has a different behavior on storybook.

@MartaPintoTeixeira MartaPintoTeixeira left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icons are missing. eg in tag template stars are gone. Also icons missing in other templates.

Assign me again when my comments above are solved.

@MartaPintoTeixeira MartaPintoTeixeira removed their assignment Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

docs[dev]: ✨ add link from templates to components and styles

4 participants