feat: add vertical stack variant to horizontal navigation item#3071
Open
martascorreia wants to merge 10 commits into
Open
feat: add vertical stack variant to horizontal navigation item#3071martascorreia wants to merge 10 commits into
martascorreia wants to merge 10 commits into
Conversation
github-project-automation
Bot
moved this to 📋 Backlog
in Solid Design System Project Board
martascorreia
changed the title
🦋 Changeset detectedLatest commit: 5c2cde5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
martascorreia
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Contributor
|
🚀 Storybook has been deployed for branch |
martascorreia
temporarily deployed
to
github-pages
GitHub Actions
Inactive
…em' of https://github.com/solid-design-system/solid into feat/vertical-stack-variant-to-horizontal-navigation-item
martascorreia
moved this from 📋 Backlog
to 👀 In review
in Solid Design System Project Board
martascorreia
temporarily deployed
to
github-pages
GitHub Actions
Inactive
coraliefeil
reviewed
Jun 11, 2026
| <sd-icon name="system/image"></sd-icon> | ||
| <span>Navigation</span> | ||
| </sd-navigation-item> | ||
| <sd-navigation-item stacked disabled> |
Contributor
There was a problem hiding this comment.
Remove disabled, current, current disabled here - we only show the stacked in default
Contributor
|
Approved after comment above has been addressed. Thanks a lot. Good job @martascorreia <3 |
martascorreia
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Contributor
Author
Thank you, team effort! 😊 |
martascorreia
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
@martascorreia Looks good to me |
coraliefeil
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
closes: #2990
Definition of Reviewable: