Skip to content

CTAP1 and CTAP2 were renamed in fido2, but not updated in devices/solo_v1.py #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mprock-blair wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CTAP1 and CTAP2 were renamed in fido2, but not updated in devices/solo_v1.py #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions solo/devices/solo_v1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@

from fido2.client import Fido2Client
from fido2.ctap import CtapError
from fido2.ctap1 import CTAP1
from fido2.ctap2 import CTAP2
from fido2.ctap1 import Ctap1
from fido2.ctap2 import Ctap2
from fido2.hid import CTAPHID, CtapHidDevice
from intelhex import IntelHex

Expand Down Expand Up @@ -64,9 +64,9 @@ def find_device(self, dev=None, solo_serial=None):
dev = devices[0]
self.dev = dev

self.ctap1 = CTAP1(dev)
self.ctap1 = Ctap1(dev)
try:
self.ctap2 = CTAP2(dev)
self.ctap2 = Ctap2(dev)
except CtapError:
self.ctap2 = None

Expand Down