Add ICCAD-2013 sample #666

c1ydehhx · 2026-01-31T03:38:25Z

In this PR, I added the mesh sample that draw the example in ICCAD-2013 CAD Contest paper. The result looks like this:

yungyuc

Good start. Points to address:

Avoid and remove Python type annotation.
Remove _fp64p().
~~Use real number format (e.g., 70.0) for the coordinates.~~
Data and logic should be separated. Make data a string and logic in a helper class.

yungyuc · 2026-01-31T03:42:09Z

modmesh/pilot/_mesh.py

+
+            return spad
+
+        def poly_spad(coords: list[tuple[int, int]]):


Don't use type annotation in modmesh. Keep Python dynamic. When types are needed, do it in C++.

yungyuc · 2026-01-31T03:43:13Z

modmesh/pilot/_mesh.py

+    def mesh_iccad_2013(self):
+        world = core.WorldFp64()
+
+        def _fp64p(x, y):


Remove _fp64p(). It is redundant. Just use Point3dFp64 constructor. If the class name is too long to you, use a local alias.

yungyuc · 2026-01-31T03:44:32Z

modmesh/pilot/_mesh.py

+
+            return spad
+
+        world.add_segments(pad=rect_spad(70, 800, 180, 40))


Use real number format (e.g., 70.0) for the coordinates.

yungyuc · 2026-01-31T03:46:33Z

modmesh/pilot/_mesh.py

        self._pycon.writeToHistory(f"tri nedge: {mh.nedge}\n")

+    def mesh_iccad_2013(self):
+        world = core.WorldFp64()


Data and logic should be separated. Make data a string and logic in a helper class.

c1ydehhx · 2026-01-31T05:32:49Z

Hi, @yungyuc. I already fix all comment:

I create a helper class named ICCAD2013Mesh. It accept the string format of ICCAD2013 table 1 to draw polygons.

    def mesh_iccad_2013(self):
        mesh = iccad_2013.ICCAD2013Mesh()
        mesh.add_item("RECT N M1 70 800 180 40")
        mesh.add_item(
            "PGON N M1 70 720 410 720 410 920 70 920 70 880 370 880 370 760 70 760"
        )
        mesh.add_item("RECT N M1 70 1060 180 40")
        mesh.add_item(
            "PGON N M1 70 980 410 980 410 1180 70 1180 70 1140 370 1140 370 1020 70 1020"
        )

        wid = self._mgr.add3DWidget()
        wid.updateWorld(mesh.get_world())
        wid.showMark()

ICCAD2013Mesh will parse string and store coordinate value as float. Add segment with its private function (rect_spad, poly_spad). add_item function will fetch first string segment to determine the item is polygon or rectangle, then transform the data as SegmentPadFp64 format. The mesh will produce world for widget.

yungyuc

Points to address:

Rename iccad_2013 to plain_layer, and the class name PlaneLayer.
Move plane_layer to be under modmesh.plot.
Move the GUI code to a new sub-module modmesh._canvas.
Use a separate PR to maintain dot files.
Rename _rect_spad() to add_rectangle() (drop leading underscore).
Rename _polygon_spad() to add_polygon() (drop leading underscore).
Rename add_item() to add_figure().

yungyuc · 2026-01-31T05:45:08Z

modmesh/pilot/_canvas.py

@@ -0,0 +1,33 @@
+# Copyright (c) 2026, Han-Xuan Huang <c1ydehhx@gmail.com>


This (iccad_2013) is a horrible name for a graphical data processor. Name it more generic. I propose to name the module as plain_layer, and use PlaneLayer as the class name. "Plane" implies the two dimension.

The module should be moved under modmesh.plot, which has nothing to do with GUI.

Also read the code under cpp/modmesh/universe, which is the graphical C++ code that @tigercosmos is working on.

yungyuc · 2026-01-31T05:51:43Z

.gitignore

 *.pdb
 *.env
 profiling/results/
+.cache


Do not change dot files when adding feature. Use a separate PR to maintain dot files.

yungyuc · 2026-01-31T05:53:34Z

modmesh/pilot/_mesh.py


 from .. import core
 from ._gui_common import PilotFeature
+from . import iccad_2013


Use a new module for drawing exclusively 2D graphics. I propose to name it modmesh._canvas (we may change it in the future).

yungyuc · 2026-01-31T05:55:29Z

modmesh/pilot/iccad_2013/_iccad_2013_mesh.py

+    def __init__(self):
+        self.world = core.WorldFp64()
+
+    def _rect_spad(self, x, y, w, h):


Rename _rect_spad() to add_rectangle().

yungyuc · 2026-01-31T05:55:52Z

modmesh/pilot/iccad_2013/_iccad_2013_mesh.py

+
+        return spad
+
+    def _poly_spad(self, coords):


Rename _polygon_spad() to add_polygon().

yungyuc · 2026-01-31T05:56:42Z

modmesh/pilot/iccad_2013/_iccad_2013_mesh.py

+
+        return spad
+
+    def add_item(self, str):


Rename add_item() to add_figure().

c1ydehhx · 2026-01-31T06:41:29Z

Hi @yungyuc. I already fix the issue in comment.

I create PlaneLayer class with Layer abstract. The class returns polys list as data that can transform as segment for world. Moreover, I create Canva to create world and transform polys list to segment that can append to world. The class Canva returns world that cae use in pilot widget. It seperate GUI and data as different class.

I still need to add some tests for these class.

yungyuc

Some points were not addressed. New points to address:

Do not add Layer. It is not a necessary abstraction.
The code for GUI should also be moved in _canvas.py.

yungyuc · 2026-01-31T06:44:35Z

modmesh/plot/plane_layer.py

+from abc import ABC
+
+
+class Layer(ABC):


Do not add Layer. It is not a necessary abstraction.

And I do not want to have a class of such a short name.

yungyuc · 2026-01-31T06:49:32Z

modmesh/pilot/_mesh.py

            func=self.mesh_3dmix,
        )

+        self._add_menu_item(


The code to great GUI should also be moved in _canvas.py. You may also need a new menu.

c1ydehhx · 2026-01-31T07:38:13Z

I fixed all issues. @yungyuc

I create canva menu that can render ICCAD example.

and I remove abstract class. Please review it, thanks.

yungyuc

Point to address:

_canvas should be before _profiling.

yungyuc · 2026-01-31T07:46:05Z

modmesh/pilot/_gui.py

    from . import _svg_gui
    from . import _linear_wave
    from . import _profiling
+    from . import _canvas


_canvas should be before _profiling.

Fixed. Thanks for the notice.

yungyuc · 2026-01-31T14:30:10Z

@c1ydehhx leave a global comment to notify when it's ready for the next review.

yungyuc · 2026-02-02T12:09:36Z

@c1ydehhx update?

c1ydehhx · 2026-02-02T13:57:12Z

Hi @yungyuc. I already fix the issue in comment. Thanks.

yungyuc

Hi @yungyuc. I already fix the issue in comment. Thanks.

No, you didn't. Please review the code carefully and update.

And please rebase to the latest, squash the commits, and write a concise summary in the commit log.

yungyuc · 2026-02-02T14:32:55Z

cpp/modmesh/pilot/RManager.cpp

    }
    m_oneMenu = m_mainWindow->menuBar()->addMenu(QString("One"));
    m_meshMenu = m_mainWindow->menuBar()->addMenu(QString("Mesh"));
+    m_canvaMenu = m_mainWindow->menuBar()->addMenu(QString("Canva"));


It's a typo. The name should be canvas, not canva.

yungyuc · 2026-02-02T14:33:27Z

cpp/modmesh/pilot/RManager.hpp

    QMenu * oneMenu() { return m_oneMenu; }
    QMenu * meshMenu() { return m_meshMenu; }
    QMenu * profilingMenu() { return m_profilingMenu; }
+    QMenu * canvaMenu() { return m_canvaMenu; }


This canvasMenu should use the same order to be placed before profilingMenu.

c1ydehhx force-pushed the ICCAD-2013-sample branch from 0dfbf91 to 72a9233 Compare January 31, 2026 03:44

yungyuc requested changes Jan 31, 2026

View reviewed changes

yungyuc assigned c1ydehhx Jan 31, 2026

yungyuc added the pilot GUI and visualization label Jan 31, 2026

c1ydehhx force-pushed the ICCAD-2013-sample branch 2 times, most recently from cf3a3ef to 7dd7fc4 Compare January 31, 2026 05:29

c1ydehhx force-pushed the ICCAD-2013-sample branch from 7dd7fc4 to fcf722b Compare January 31, 2026 05:33

yungyuc requested changes Jan 31, 2026

View reviewed changes

c1ydehhx force-pushed the ICCAD-2013-sample branch 2 times, most recently from 82f11b5 to 46d7b44 Compare January 31, 2026 06:36

yungyuc requested changes Jan 31, 2026

View reviewed changes

c1ydehhx force-pushed the ICCAD-2013-sample branch 2 times, most recently from 8c3b971 to 7d93610 Compare January 31, 2026 07:55

Add ICCAD-2013 sample

4236eb7

c1ydehhx force-pushed the ICCAD-2013-sample branch from 7d93610 to 4236eb7 Compare January 31, 2026 08:19

Add ICCAD-2013 sample

ddf4e92

yungyuc requested changes Feb 2, 2026

View reviewed changes


		return spad

		world.add_segments(pad=rect_spad(70, 800, 180, 40))

		@@ -0,0 +1,33 @@
		# Copyright (c) 2026, Han-Xuan Huang <c1ydehhx@gmail.com>

Add ICCAD-2013 sample #666

Are you sure you want to change the base?

Add ICCAD-2013 sample #666

Conversation

c1ydehhx commented Jan 31, 2026

Uh oh!

yungyuc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

c1ydehhx commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yungyuc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

c1ydehhx commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yungyuc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

c1ydehhx commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yungyuc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yungyuc commented Jan 31, 2026

Uh oh!

yungyuc commented Feb 2, 2026

Uh oh!

c1ydehhx commented Feb 2, 2026

Uh oh!

yungyuc left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

yungyuc left a comment •

edited

Loading

c1ydehhx commented Jan 31, 2026 •

edited

Loading

yungyuc left a comment •

edited

Loading

c1ydehhx commented Jan 31, 2026 •

edited

Loading

yungyuc left a comment •

edited

Loading

c1ydehhx commented Jan 31, 2026 •

edited

Loading

yungyuc left a comment •

edited

Loading