Skip to content

Fixed #12, CSS for fields with no value #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timohausmann wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed #12, CSS for fields with no value #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf04453
Fix: Hexcodes starting with 0E becoming 000000
timohausmann Oct 18, 2022
4a07b57
indicate not set color in UI
timohausmann Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions FieldtypeColorPicker.module
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class FieldtypeColorPicker extends Fieldtype {
*
*/
public function getBlankValue(Page $page, Field $field) {
if($field->default == "0") $field->default = "000000";
if($field->default === "0") $field->default = "000000";
return $field->default ? $field->default : '';
}

Expand Down Expand Up @@ -62,7 +62,7 @@ class FieldtypeColorPicker extends Fieldtype {
if(!$field->formatting) return $value;

if("transp" == strtolower($value)) return self::TRANSPARENT;
if($value == "0") $value = "000000";
if($value === "0") $value = "000000";

return self::HEX_PREFIX . $value;
}
Expand Down
6 changes: 6 additions & 0 deletions colorpicker/css/colorpicker.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,3 +162,9 @@
.colorpicker_slider {
background-position: bottom;
}


.colorpicker_loaded:has(+ input:not([value])),
.colorpicker_loaded:has(+ input[value=""]) {
background: linear-gradient(-45deg, white 47%, red 48%, red 52%, white 53%) !important;
}