Change the timeout to drop unacked messages to 60 seconds#161
Merged
Conversation
Signed-off-by: BYGX-wcr <wcr@live.cn>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This PR updates the swbus-actor outgoing-message maintenance logic to shorten the time window before unacked messages are dropped, aiming to prevent long-lived unacked messages from blocking actor deletion.
Changes:
- Reduced the “drop unacked messages” timeout from 1 hour to 60 seconds in the outgoing maintenance loop.
- Updated the inline comment to reflect the new timeout.
Signed-off-by: BYGX-wcr <wcr@live.cn>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yue-fred-gao
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Change the timeout to drop unacked messages to 60 seconds.
Why I did it
Previously, an actor message will not be dropped until it waits in the queue for an hour. In cases where unacked messages are inevitable, this can block the deletion of an actor.
How I verified it
Details if related