Fix kdump unit tests by correctly mocking /proc/cmdline#351
Open
vivekverma-arista wants to merge 1 commit into
Open
Fix kdump unit tests by correctly mocking /proc/cmdline#351vivekverma-arista wants to merge 1 commit into
/proc/cmdline#351vivekverma-arista wants to merge 1 commit into
Conversation
Signed-off-by: Vivek Kumar Verma <vivekverma@arista.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Author
|
@qiluo-msft can you review? |
vivekverma-arista
changed the title
/proc/cmdline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #350
Refer the above issue for details.
Affected Tests
How did I fix it?
The proposed fix is to properly mock cmdline for each of the tests instead of referring to the actual
/proc/cmdlinefrom the machine on which the test is running.crashkernelhas been removed from/proc/cmdlineas all tests excepthostcfgd_test.pyexpect kdump to be disabled.Since only
hostcfd_test.pyexpects kdump to be enabled, the parameter is explicitly injected to cmdline during setup phase of the test and reverted during teardown so that it doesn't affect other tests.