Debian Trixie migration for sonic-mgmt-common#211
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Amruta Sali <amruta_sali@dell.com>
Signed-off-by: Amruta Sali <amruta_sali@dell.com>
amrutasali
force-pushed
the
trixie_migration_for_sonic_mgmt_common
branch
from
be6236e to
9aa7f8b
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
This PR updates sonic-mgmt-common build and CI configuration to support Debian Trixie, aligning with the broader SONiC Trixie migration so downstream projects (notably sonic-mgmt-framework) can build and run on the new distro.
Changes:
- Switch Azure Pipelines build container and artifact paths from Bookworm to Trixie, including installing libpcre3 packages required by libyang.
- Bump the module Go version to Go 1.24.4.
- Adjust translib YGOT binding generation to account for Go 1.24+ vendoring behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
azure-pipelines.yml |
Migrates pipeline container/artifact paths to Trixie and installs additional Debian dependencies. |
go.mod |
Updates declared Go version for the module. |
translib/Makefile |
Attempts to patch vendoring metadata to allow go run of vendored ygot generator under Go 1.24+. |
cvl/cvl.go |
Minor logging call adjustment while parsing schema files. |
…ding raw package paths Signed-off-by: Amruta Sali <amruta_sali@dell.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…l using a hard-coded wheel filename (sonic_yang_models-1.0-py3-none-any.whl) Signed-off-by: Amruta Sali <amruta_sali@dell.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@saiarcot895 can you please review/merge this so that the submodule can be updated since this PR for trixie migration needs it. I'm not able to add any reviewers. |
#### Why I did it - Required for sonic-net/SONiC#2169 #### How I did it - Updated Azure Pipelines to use sonic-slave-trixie container Added libpcre3 dependencies (not available in Trixie repos) Bumped Go version to 1.24.4 to align with Trixie's provided version Updated dependency paths to use Trixie-specific packages and Python wheels #### How to verify it - The sonic-mgmt-framework container builds successfully under BLDENV=trixie. Installed it on a recent SONiC image and verified that the docker os distribution shows Trixie and basic curl test on REST server hosted within the docker works fine. Also executed the pipeline tests locally. **Note:** Dependent/Related PRs: sonic-net/sonic-buildimage#26548 sonic-net/sonic-mgmt-common#211 * Debian Trixie migration for sonic-mgmt-framework Signed-off-by: Amruta Sali <amruta_sali@dell.com> * modified azure-pipelines.yml for pip install to use wildcard for filename (sonic_yang_models-1.0-py3-none-any.whl) Signed-off-by: Amruta Sali <amruta_sali@dell.com> --------- Signed-off-by: Amruta Sali <amruta_sali@dell.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@saiarcot895 the pipeline run is successful , This PR is ready to be merged |
|
Hi @amrutasali, could you please help check the build failure in submodule advanced PR sonic-net/sonic-buildimage#26780, seems like the build failure is related with your changes. maybe the go version in go.mod file needs to be 1.24 instead of 1.24.4? submodule advanced PR for sonic-mgmt-framework is also blocked sonic-net/sonic-buildimage#26781 by sonic-net/sonic-mgmt-framework#158. Seems like a different issue. Could you help check? Thanks! |
@yijingyan2 PR #26548 needs to be merged before the submodule update PRs can succeed. The sonic-mgmt-common/go.mod file now specifies : go 1.24.4 From the build logs it is seen that bookworm environment is being used to build sonic-mgmt-common and sonic-mgmt-framework: |
Why I did it -
Required for sonic-net/SONiC#2169 , sonic-mgmt-common is a dependency for sonic-mgmt-framework
How I did it -
Updated the package build configuration to support Trixie distro. Key changes include:
Updated Azure Pipelines to use sonic-slave-trixie container
Added libpcre3 dependencies (not available in Trixie repos)
Bumped Go version to 1.24.4 to align with Trixie's provided version
Fixed Go 1.24+ vendor module requirements for ygot tool
How to verify it -
The sonic-mgmt-framework container builds successfully under BLDENV=trixie which in turn builds sonic-mgmt-common(the .deb built was correctly paced in target/debs/trixie). Installed sonic-mgmt-framework container on a recent SONiC image and verified that the docker OS distribution shows Trixie and basic curl test on REST server hosted within the docker works fine. Also executed the pipeline tests locally.
Note:
Dependent/Related PRs:
sonic-net/sonic-buildimage#26548
sonic-net/sonic-mgmt-framework#158