Skip to content

Skip updating WRED profiles with wred_green_enabled=false#24532

Merged
mramezani95 merged 1 commit into
sonic-net:masterfrom
mramezani95:mramezani/test_ecn_config_update_fix_master
May 12, 2026
Merged

Skip updating WRED profiles with wred_green_enabled=false#24532
mramezani95 merged 1 commit into
sonic-net:masterfrom
mramezani95:mramezani/test_ecn_config_update_fix_master

Conversation

@mramezani95
Copy link
Copy Markdown
Contributor

Description of PR

This PR ports the following two PRs from 202412 to master:
Azure/sonic-mgmt.msft#1024
Azure/sonic-mgmt.msft#1188

Summary:
Skip updating WRED profiles for which wred_green_enabled is false.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505
  • 202511

Approach

What is the motivation for this PR?

Ensuring that tests don't fail when for some WRED profiles, wred_green_enabled=false.

How did you do it?

We set all delta values to 0 if wred_green_enabled=false for a WRED profile and do not create a JSON patch for that profile.

How did you verify/test it?

Ran the tests:

generic_config_updater/test_ecn_config_update.py::test_ecn_config_updates[None-replace-green_min_threshold] PASSED                                    [ 25%]
generic_config_updater/test_ecn_config_update.py::test_ecn_config_updates[None-replace-green_max_threshold] PASSED                                    [ 50%]
generic_config_updater/test_ecn_config_update.py::test_ecn_config_updates[None-replace-green_drop_probability] PASSED                                 [ 75%]
generic_config_updater/test_ecn_config_update.py::test_ecn_config_updates[None-replace-green_min_threshold,green_max_threshold,green_drop_probability] PASSED [100%]

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

N/A

Documentation

N/A

Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>
@mramezani95 mramezani95 requested review from r12f and sdszhang May 12, 2026 02:44
@mramezani95 mramezani95 added the Request for 202511 branch Request to backport a change to 202511 branch label May 12, 2026
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Request for 202511 branch Request to backport a change to 202511 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants