Remove unused cmisCDB file#679
Merged
Merged
Conversation
Signed-off-by: Prince George <prgeor@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a legacy CMIS CDB API implementation and its associated unit test from sonic_platform_base, aiming to eliminate an unused module from the transceiver API surface.
Changes:
- Deleted
sonic_platform_base/sonic_xcvr/api/public/cmisCDB.py(CDB command API implementation). - Deleted
tests/sonic_xcvr/test_cmisCDB.py(unit tests covering the removed API).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/sonic_xcvr/test_cmisCDB.py | Removes unit tests that exercised the legacy CmisCdbApi implementation. |
| sonic_platform_base/sonic_xcvr/api/public/cmisCDB.py | Removes the legacy public CMIS CDB API module (CmisCdbApi). |
Comments suppressed due to low confidence (1)
sonic_platform_base/sonic_xcvr/api/public/cmisCDB.py:1
- Removing this module is a backwards-incompatible API break: any downstream code importing
sonic_platform_base.sonic_xcvr.api.public.cmisCDB.CmisCdbApiwill fail at import time after upgrading. Consider keepingcmisCDB.pyas a compatibility shim (e.g., re-export/forward to the newer CDB firmware API) and deprecate it before removing in a major-version change.
Contributor
|
LGTM |
yxieca
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove unused cmisCDB.py
How Has This Been Tested?
Unit test is sufficient.
Additional Information (Optional)