Sonic vpp docker image build support#201
Open
Aditi105 wants to merge 2 commits into
Open
Conversation
|
|
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
| @@ -0,0 +1,25 @@ | |||
| # Copyright 2016 Microsoft, Inc. | |||
Contributor
There was a problem hiding this comment.
Many of the .mk and .dep already exist in rules/. Can we reuse them?
|
|
||
| $(LIBSAIREDIS)_DEB_BUILD_PROFILES += syncd vs | ||
|
|
||
| # VPP uses the virtual switch syncd since it operates in software dataplane mode |
Contributor
There was a problem hiding this comment.
Do we need to introduce SYNCD_VPP? can we change the caller to SYNCD_VS instead?
| include $(PLATFORM_RULES)/one-image.mk | ||
| include $(PLATFORM_RULES)/onie.mk | ||
| include $(PLATFORM_RULES)/kvm-image.mk | ||
| include $(PLATFORM_RULES)/raw-image.mk |
Contributor
There was a problem hiding this comment.
What's the benefit to move them out of rules/?
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr contains all the changes required to build sonic vpp docker image.