Add validation for malformed interface ranges#4575
Open
bgallagher-nexthop wants to merge 1 commit into
Open
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Brian Gallagher <bgallagher@nexthop.ai>
78aeec5 to
f564f45
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4574.
What I did
It is possible to run
sudo config interface startup Ethernet320-Ethernet376orsudo config interface shutdown Ethernet320-Ethernet376and the command will return silently without actually having done anything because the valid format for a range specifier isEthernet320-376.This PR adds validation to these CLI commands so that malformed range specifiers will cause the CLI to print an error message.
How I did it
I added logic to raise an exception when a malformed range specifier is provided by the user to the CLI.
How to verify it
Added unit-tests, manually tested below.
Previous command output (if the output of a command-line utility has changed)
Before the change:
New command output (if the output of a command-line utility has changed)
After the change: