Skip to content

SWWH025-11 Heat Pump Water Heater, Res, FS Update#168

Open
SJeffery97 wants to merge 1 commit into
sound-data:mainfrom
TRC-RTC:SWWH025-11-Heat-Pump-Water-Heater-Res-FS
Open

SWWH025-11 Heat Pump Water Heater, Res, FS Update#168
SJeffery97 wants to merge 1 commit into
sound-data:mainfrom
TRC-RTC:SWWH025-11-Heat-Pump-Water-Heater-Res-FS

Conversation

@SJeffery97
Copy link
Copy Markdown
Contributor

SWWH025-11 HPWH, Res, FS Update

Energy modeling: Sophiya Jeffery
Postprocessing: Sophiya Jeffery

This midcycle update includes updating standard gas baseline and adding existing gas baseline in the cases files to align with new federal code. Additional changes were made to clean up the measure folder by deleting unused cases files.

Energy Consumption:
meas_impacts_2022_res.csv

Measure List:
DEER_EnergyPlus_Modelkit_Measure_list_working_120v.xlsx
DEER_EnergyPlus_Modelkit_Measure_list_working_240v.xlsx

PR Author

  • Make sure the PR branch is up to date with main branch at the time of the PR submission
  • Craft a succinct title that effectively encapsulates the essence of the pull request, providing a general overview of the proposed changes.
  • Label the PR with at least one of the following: New Measure, Bug, or Feature.
  • Provide a concise description of the measure, bug, or feature. Submit one PR per measure.
  • For a new measure, attach a workbook named DEER_EnergyPlus_Modelkit_Measure_list_working.xlsx, containing only rows used for post-processing the measure.
  • Add comments in the code when necessary to facilitate the review process.
  • Add a comment before the added code, including the author's full name, company, and specifying if it's a bug fix, new measure, or feature.
  • For a new feature or bug, demonstrate the impact on energy consumption for selected cases with justification using plots and descriptions.
  • For a new measure, add a summary table showing total energy consumption per simulated case.

PR Reviewer

  • Conduct a thorough code review.
  • If the branch is behind the main, merge the branch locally to check for potential conflicts.
  • If a bug, locally reproduce it and compare energy consumptions before and after.
  • Explore creative ways to stress-test the code.
  • Locally check the error file and other outputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant