send good notification when the previously down service is helathy again #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Sep 14, 2018
ghost
commented
mholt
requested changes
Nov 18, 2018
Collaborator
mholt
left a comment
mholt
left a comment
There was a problem hiding this comment.
Thanks! Just a couple minor changes.
| for _, result := range results { | ||
| if !result.Healthy { | ||
| s.Send(result) | ||
| notifications[result.Title] = 1 |
Collaborator
There was a problem hiding this comment.
Instead of using magic numbers, let's use a defined constant here.
| slack "github.com/ashwanthkumar/slack-go-webhook" | ||
| ) | ||
|
|
||
| var notifications = make(map[string]int) |
Collaborator
There was a problem hiding this comment.
Move to the bottom of the file, with some whitespace around it, rather than crowding the unrelated comment on the line below.
| s.Send(result, "danger") | ||
| } else if notifications[result.Title] == 1 { | ||
| notifications[result.Title] = 0 | ||
| s.Send(result, "good") |
Collaborator
There was a problem hiding this comment.
While we're at it, I wonder if the colors should be moved into constants as well.
|
Guys this would also be great to have for the other Notifiers! |
|
Is this PR still valid? If we're talking about a couple constants and things like that... I have a fork already 🤷♀️ Would be a monster rebase, maybe, because it's so old :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.