fix: Filter toggle button & Search field style updated in responsive device#2625
fix: Filter toggle button & Search field style updated in responsive device#2625iamibrahimriaz wants to merge 14 commits intosovware:developmentfrom
Conversation
|
It looks way better inside the header when the header is enabled, when its enabled can it nest nicely with the other icons? |
…into improve/filter-btn-placement
|
@iamibrahimriaz Please add a listing shortcode and Gutenberg block on a same page (https://imgur.com/HqTVQhA |
…into improve/filter-btn-placement
@gaa23 The filter toggle button should be separate from the header because the header is an individual module. |
…into improve/filter-btn-placement
…into improve/filter-btn-placement
Fixed |
|
@iamibrahimriaz The header is still visible in the responsive view even when it’s disabled, so it’s not working as described (Guteberg block) |
…into improve/filter-btn-placement
|
@iamibrahimriaz When the sidebar is set to popup filter and the filter button is enabled, it doesn’t appear on the frontend (likely already present in the development branch — adjustment needed to complete this PR). https://prnt.sc/-E4KZKBJKsQs |
|
@RabbiIslamRony its need to fix on another PR. This PR is only for sidebar filter toggle button in responsive device. It will be great, if you create an issue in details. |
|
@iamibrahimriaz During investigation, the previous responsive breakpoint was 991px. After fixing the filter toggler button, it is now 767px — please note that the responsive media breakpoint has been changed. |
|
@RabbiIslamRony Breakpoint was intentionally changed after discussion with the CPO. |
|
@iamibrahimriaz Clicking “Select” in the search area causes the sidebar to hide automatically. https://prnt.sc/XR5LLqejsgcy |
It's not related to this PR. Need another PR to fix this issue. |
…into improve/filter-btn-placement
PR Type
What kind of change does this PR introduce?
Description
Disabling the Listing header no longer hides the sidebar toggle button in responsive view, since the toggler has been moved outside the header section.
Before: https://prnt.sc/CjtoJuSjP2VW | https://prnt.sc/NYsKsz-wQ4Yf
After: https://prnt.sc/pChmYOLX2l2t , https://prnt.sc/m7EGu-wqusME
Also updated the responsive media breakpoint from 991px to 767px. https://prnt.sc/yxZcHnc5lMSP
Any linked issues
Fixes #
Checklist