Fix: Missing Font Awesome regular SVG icons not rendering on frontend#2708
Open
RabbiIslamRony wants to merge 1 commit intosovware:developmentfrom
Open
Fix: Missing Font Awesome regular SVG icons not rendering on frontend#2708RabbiIslamRony wants to merge 1 commit intosovware:developmentfrom
RabbiIslamRony wants to merge 1 commit intosovware:developmentfrom
Conversation
Add the following regular-style SVGs that were absent from the local icon set but present in the official Font Awesome 5.15.4 distribution: - arrow-alt-circle-down - arrow-alt-circle-left - arrow-alt-circle-right - arrow-alt-circle-up - calendar-alt - comment-alt - file-alt - grin-alt - list-alt - money-bill-alt - trash-alt
Collaborator
|
Looks Good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Description
When a user selects certain Font Awesome regular icons via the Directory Builder → Icon Picker in the admin panel, those icons fail to render on the frontend. This happens because 11 regular-style SVG files were missing from the local icon set under
assets/icons/font-awesome/svgs/regular/.Missing icons added:
arrow-alt-circle-down,arrow-alt-circle-left,arrow-alt-circle-right,arrow-alt-circle-up,calendar-alt,comment-alt,file-alt,grin-alt,list-alt,money-bill-alt,trash-altHow to reproduce
far fa-calendar-alt,far fa-trash-alt).Any linked issues
Fixes #
#2699
Checklist