feat: enhance OpenAI message conversion for Gemini compatibility#489
Draft
LeeroyDing wants to merge 2 commits intospacedriveapp:mainfrom
Draft
feat: enhance OpenAI message conversion for Gemini compatibility#489LeeroyDing wants to merge 2 commits intospacedriveapp:mainfrom
LeeroyDing wants to merge 2 commits intospacedriveapp:mainfrom
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gemini API is... weird, to say the least. Should fix #461
Note
This PR enhances OpenAI message conversion to handle Gemini API's strict compatibility requirements. The Gemini API uses an OpenAI-compatible shim but has several quirks that differ from standard OpenAI:
Key changes:
is_geminiparameter toconvert_messages_to_openai()to conditionally handle Gemini-specific formattingcontentis now an empty string""instead ofnullwhen tool calls are present (required by Gemini)indexfield (0-based) in Gemini modenamefield for Gemini (in addition totool_call_id)SpacebotModelto pass theis_geminiflag based onApiTypeWritten by Tembo for commit 01a4f9f. This will update automatically on new commits.