fix: suppress avatar 404s and chart dimension warnings#494
Open
TheDarkSkyXD wants to merge 1 commit intospacedriveapp:mainfrom
Open
fix: suppress avatar 404s and chart dimension warnings#494TheDarkSkyXD wants to merge 1 commit intospacedriveapp:mainfrom
TheDarkSkyXD wants to merge 1 commit intospacedriveapp:mainfrom
Conversation
- Remove eager avatar URL from topology graph nodes — agents without
custom avatars were triggering 404 console errors on every render.
The gradient fallback avatars display correctly without the URL.
- Add debounce={1} to ResponsiveContainer in AgentDetail charts to
prevent the "width(-1) and height(-1)" warnings on initial mount.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
WalkthroughTwo files modified: removed avatar URL resolution from graph agent nodes in TopologyGraph, and added debounce configuration to chart container components in AgentDetail for resize handling optimization. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
avatarUrlfrom topology graph agent nodes — agents without custom avatars were triggering 404 console errors on every render. Gradient fallback avatars display correctly without the URL.debounce={1}toResponsiveContainerin AgentDetail charts (MemoryGrowthChart, ProcessActivityChart, MemoryDonut) to prevent the "width(-1) and height(-1)" warnings on initial mount.Test plan
GET /api/agents/avatar?agent_id=... 404errors in console on the overview/topology page🤖 Generated with Claude Code