Add a shouldStopCallback hook for graceful external stops#504
Merged
freekmurze merged 2 commits intospatie:mainfrom Apr 15, 2026
Merged
Add a shouldStopCallback hook for graceful external stops#504freekmurze merged 2 commits intospatie:mainfrom
freekmurze merged 2 commits intospatie:mainfrom
Conversation
Contributor
Author
|
Little ping @freekmurze 🙏 |
freekmurze
approved these changes
Apr 15, 2026
Member
freekmurze
left a comment
There was a problem hiding this comment.
Clean implementation that follows the existing fluent API patterns. Good phpdoc, the callback is only invoked when set (no perf impact for existing users), and test coverage covers both immediate and mid-crawl stops. CI is green across all matrix jobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a shouldStopCallback hook for graceful external stops
shouldStopflag, which makes these integrations awkward and pushes tests toward mutating internal state.shouldStopCallback()hook that is evaluated before scheduling each next request. When it returnstrue, the crawl stops gracefully andstart()returnsFinishReason::Interrupted.