feat(dashboard): full-height sidebar shell (Vercel-style layout)#3015
feat(dashboard): full-height sidebar shell (Vercel-style layout)#3015simplesagar wants to merge 1 commit into
Conversation
Flips the app layout grid so the sidebar runs the full vertical extent of the page and the TopHeader sits only over the content column. - AppLayout / OrgLayout: outer flex changes from column to row - SidebarProvider: --header-offset defaults to 0 (was 3.5rem when not impersonating); only the impersonation banner shifts the sidebar - TopHeader: stripped of logo, org slug, and user avatar — kept project switcher, breadcrumb anchor, Docs/Changelog links, plus a new SidebarTrigger - New SidebarBrand mounts at the top of AppSidebar / OrgSidebar - New SidebarUserMenu mounts at the bottom of both sidebars - ThemeSwitcher moved into the user dropdown Targets the org-home redesign branch — meant to land on top of that work before merging the whole thing into main. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary
Stacks on top of #3014 — flips the app layout grid so the sidebar runs the full vertical extent of the page (top: 0 → bottom: 0), Vercel-style. The
TopHeaderis no longer a full-width strip across the whole app; it sits only over the content column.What moved where
Layout change
Why this PR targets the org-home branch
The org home redesign (#3014) and this shell change touch overlapping surface. Landing them as one PR would explode the diff; sequencing them lets each get a focused review. Once both ship, the combined effect is the Vercel-style org overview we've been iterating on.
New components
SidebarBrand— reusable logo + org-slug strip mounted in bothAppSidebarandOrgSidebarvia<SidebarHeader>SidebarUserMenu— user dropdown extracted from TopHeader, mounted in<SidebarFooter>. ThemeSwitcher folded in.CSS variable change
--header-offsetdefaults to0rem(previously3.5remwhen not impersonating). Only the impersonation banner shifts the sidebar down now — the TopHeader no longer takes vertical space above the sidebar because it lives inside the content column.Test plan
/<orgSlug>,/<orgSlug>/audit-logs,/<orgSlug>/team,/<orgSlug>/access) — sidebar extends full height, TopHeader strip is only over the right column/<orgSlug>/projects/<slug>and sub-pages) — same; project switcher still works in the TopHeader