fix(triggers): include fired and cancelled in instance status enum#3016
Open
danielkov wants to merge 1 commit into
Open
fix(triggers): include fired and cancelled in instance status enum#3016danielkov wants to merge 1 commit into
danielkov wants to merge 1 commit into
Conversation
The triggers list endpoint advertised status as `active|paused`, but wake triggers transition through `fired` and `cancelled` too. The dashboard's generated SDK rejected the payload with a generic "Response validation failed", breaking the triggers page. Widens the Goa enum on the output type (CreateTriggerInstanceForm and UpdateTriggerInstanceForm inputs are left unchanged — those are user-settable states only) and regenerates the server + internal SDK. Dashboard StatusBadge gains explicit fired and cancelled cases. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
🦋 Changeset detectedLatest commit: e9115ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Triggers list response advertised
statusasactive | paused, but wake triggers transition throughfiredandcancelledtoo. The dashboard's generated SDK rejected those payloads with a generic "Response validation failed" and the triggers page failed to load whenever any wake had fired or been cancelled.TriggerInstanceoutput type.CreateTriggerInstanceFormandUpdateTriggerInstanceFormare left atactive | paused— terminal states are system-written, not user-settable.StatusBadgegets explicitfiredandcancelledcases so those instances render with a real label instead of falling through to "Paused".✻ Clauded...