Merged
Conversation
test_connection for qBittorrent and SABnzbd accessed legacy config fields (app_config.qbittorrent/sabnzbd) which are None when using the multi-client download_clients system, causing "'NoneType' object has no attribute 'password'" crashes. Updated both to use _find_existing_client() matching the pattern already used by NZBGet, Transmission, and Deluge. Added _request() wrapper to qBittorrent client that automatically re-authenticates on 403 responses, preventing persistent auth failures after session expiry. Replaced FormData with plain dicts for retry safety and added raise_for_status() calls for clearer error messages. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…torrent auth response body aiohttp's default CookieJar silently rejects cookies from IP addresses, causing qBittorrent sessions at IP-based URLs to lose their SID cookie on every request (persistent 403 loop). Use CookieJar(unsafe=True) in both the qBittorrent client and base client class. Also validate the login response body for "Ok." since qBittorrent returns HTTP 200 for both success and failure, and upgrade 403 re-auth log to info. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.