Pb active transport #1464
Merged
Pb active transport #1464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
Collaborator
Author
|
Tested on imix and imixv2.
|
hulto
commented
Dec 30, 2025
| "SetCallbackIntervalMessage: beacon is missing from config" | ||
| )), | ||
| }?; | ||
| // TODO: we can probably just modify the interval not rebuild the entire beacon see set_callback_uri.rs |
Collaborator
Author
There was a problem hiding this comment.
this is 1v we let it die 🫡
implants/lib/pb/src/config.rs
Outdated
| use crate::c2::beacon::Transport; | ||
| use crate::c2::ActiveTransport; | ||
|
|
||
| //TODO: Migrate most of this into a config crate or as a part of the agent. |
Collaborator
Author
There was a problem hiding this comment.
Feels like a good follow on PR
implants/lib/pb/src/config.rs
Outdated
| #[prost(uint64, tag = "4")] | ||
| pub retry_interval: u64, | ||
| #[prost(bool, tag = "5")] | ||
| // #[prost(string, tag = "2")] |
| let transport = crate::c2::beacon::Transport::Grpc; | ||
| #[cfg(not(any(feature = "dns", feature = "http1", feature = "grpc")))] | ||
| let transport = crate::c2::beacon::Transport::Unspecified; | ||
| let transport_type = match CALLBACK_URI.split(":").nth(0).unwrap_or("unspecified") { |
Collaborator
Author
There was a problem hiding this comment.
Probably need to add some testing to make sure the transport exists in the complied agent.
jabbate19
previously approved these changes
Dec 31, 2025
Collaborator
jabbate19
left a comment
jabbate19
left a comment
There was a problem hiding this comment.
Please consider changes for rust code to make the unboxing cleaner, but otherwise 
hulto
commented
Jan 2, 2026
KCarretto
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Refactor transport configuration.
IMIX_PROXY_URItoIMIX_TRANSPORT_EXTRA_HTTP_PROXY