fix: detect native playhtml and merge extension identity via CustomEvent#79
Open
spencerc99 wants to merge 2 commits intomainfrom
Open
fix: detect native playhtml and merge extension identity via CustomEvent#79spencerc99 wants to merge 2 commits intomainfrom
spencerc99 wants to merge 2 commits intomainfrom
Conversation
When the extension runs on a page that already uses playhtml natively, skip initializing a second instance (prevents duplicate cursors and element init errors). Instead, inject the extension's publicKey and color into the existing instance via a CustomEvent bridge that crosses Chrome's content script world boundary. The merge preserves page-set fields (name, discoveredSites, etc.) and only overwrites publicKey and playerStyle from the extension. - Add data-playhtml DOM marker in playhtml init() for cross-world detection - Add MutationObserver wait for late-loading playhtml (Vite dev server) - Add playhtml:configure-identity / playhtml:ready event handshake - Fix configure() to re-broadcast awareness and update cursor style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the extension runs on a page that already uses playhtml natively, skip initializing a second instance (prevents duplicate cursors and element init errors). Instead, inject the extension's publicKey and color into the existing instance via a CustomEvent bridge that crosses Chrome's content script world boundary.
The merge preserves page-set fields (name, discoveredSites, etc.) and only overwrites publicKey and playerStyle from the extension.