tests: add test_lnwallet to test lnwallet utils #10363
Open
+55
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds new unittest file test_lnwallet.py using the MockLNWallet from test_lnpeer to allow unittesting utility functions of LNWallet/LNWorker.
Member
|
I would very much prefer if we stopped mocking up LNWallet. Of course what I am saying is not conflicting with this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to have some way to test the (utility) methods of
LNWallet/LNWorkerto allow for more coverage and detect regressions like #10350 before they reach the GUI etc.As it feels wrong to put these tests in test_lnpeer (where we already have a
MockLNWallet), I created a new test filetest_lnwallet.py, using theMockLNWallet, specifically for testing this functionality.It currently fails because it triggers #10350