Open
Conversation
xinchaochen8
requested review from
lumjjb,
maia-iyer,
mamy-CS and
mrsabath
as code owners
maia-iyer
requested changes
Apr 14, 2025
Collaborator
maia-iyer
left a comment
maia-iyer
left a comment
There was a problem hiding this comment.
Thanks for your PR update on the Cors handling! I left an initial review on the agent code
xinchaochen8
force-pushed
the
update_cors
branch
2 times, most recently
from
52861ec to
e622e6a
Compare
Signed-off-by: Xin Chao <xinchaochen108@gmail.com>
Signed-off-by: Xin Chao <xinchaochen108@gmail.com>
resolve linting error by check return values Signed-off-by: Xin Chao <xinchaochen108@gmail.com>
`set-output` command is deprecated and upgrade it Signed-off-by: Xin Chao <xinchaochen108@gmail.com>
Signed-off-by: EURICIA <xinchaochen1095@gmail.com> Signed-off-by: Xin Chao <xinchaochen108@gmail.com>
Reverted changes for `set-output` command is deprecated and fixed some typos. Signed-off-by: Xin Chao <xinchaochen108@gmail.com>
Signed-off-by: Alan Cha <Alan.cha1@ibm.com>
Signed-off-by: Alan Cha <Alan.cha1@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces CORS (Cross-Origin Resource Sharing) support to Tornjak agent and Tornjak manager API
Changes include:
Updated server.go to integrate CORS headers.
Modified master-build.yaml for compatibility.
Merged latest main branch to resolve conflicts.
fixes #494
Signed-off-by: Xin Chao Chen xinchaochen108@gmail.com