Open
Conversation
kasiakoziol
reviewed
Mar 30, 2026
| matrix: | ||
| test: | ||
| [ | ||
| masterappframeworkc3, |
Collaborator
There was a problem hiding this comment.
We have to agree whether we want to run master tests. I had the same concern on license manager/master tests and as of now, they are not run for master.
| branches: | ||
| - develop | ||
| - main | ||
| - CSPL-4601-rebased |
Collaborator
There was a problem hiding this comment.
Please remember to remove this before merging
| - { order: 3, name: "m4_gcp_sanity" } | ||
| - { order: 4, name: "m4_mgr_gcp_sanity" } | ||
| - { order: 5, name: "s1_gcp_sanity" } | ||
| - { order: 1, name: "masterappframeworkc3" } |
| BeforeEach(func() { | ||
| var err error | ||
| name := fmt.Sprintf("%s-%s", "master"+testenvInstance.GetName(), testenv.RandomDNSName(3)) | ||
| fmt.Printf("[DEBUG] M4 BeforeEach starting, name=%s\n", name) |
Collaborator
There was a problem hiding this comment.
Are you planning to keep these "logs"?
| return | ||
| } | ||
| logf.Log.Info("[DEBUG] Pod status (wide)", "namespace", ns) | ||
| for _, line := range strings.Split(string(output), "\n") { |
Collaborator
There was a problem hiding this comment.
This could be moved to a separate function
| lines := strings.Split(string(output), "\n") | ||
| logf.Log.Info("[DEBUG] Recent events", "namespace", ns, "total", len(lines)) | ||
| start := 0 | ||
| if len(lines) > 30 { |
Collaborator
There was a problem hiding this comment.
30 could be moved to a constant and referenced from there
| return 0 | ||
| fi | ||
|
|
||
| kubectl config set-credentials ci-test-runner --token="${TOKEN}" |
Collaborator
There was a problem hiding this comment.
We need to make sure that it doesn't get printed out in the pipelines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What does this PR have in it?
Key Changes
Highlight the updates in specific files
Testing and Verification
How did you test these changes? What automated tests are added?
Related Issues
Jira tickets, GitHub issues, Support tickets...
PR Checklist