Automated release workflow permission updates#1802
Open
rlieberman-splunk wants to merge 9 commits intodevelopfrom
Open
Automated release workflow permission updates#1802rlieberman-splunk wants to merge 9 commits intodevelopfrom
rlieberman-splunk wants to merge 9 commits intodevelopfrom
Conversation
Promote Develop to main for Splunk Operator Release 3.1.0
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…10.2 Update Splunk Enterprise version to 10.2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the automated-release-workflow.yml GitHub Actions workflow, which was failing at multiple steps due to a permissions misconfiguration and cosign signature verification issues against Docker Hub.
Key Changes
Fixed OIDC permissions for AWS credential authentication: The job-level permissions block was overriding the workflow-level block, silently dropping id-token: write. This prevented aws-actions/configure-aws-credentials from obtaining an OIDC token to assume the AWS role. Added
id-token: writeto the job-level permissions block so it is preserved alongside the existing contents: write and pull-requests: write.Fixed cosign sign/verify for image on Docker Hub: Added
COSIGN_DOCKER_MEDIA_TYPES: "1"to both the sign and verify steps for splunk/splunk-operator. Docker Hub uses Docker media types rather than OCI media types, which caused cosign to store and look up signatures in mismatched formats, resulting in no signatures found. All other workflows in this repo sign against ECR (which uses OCI media types natively) and are unaffected.Fixed cosign sign/verify for images on Docker Hub: Added
COSIGN_DOCKER_MEDIA_TYPES: "1"to both the sign and verify steps. Docker Hub uses Docker media types rather than OCI media types, which caused cosign to store and look up signatures in mismatched formats, resulting in no signatures found. All other workflows in this repo sign against ECR (which uses OCI media types natively) and are unaffected. Additionally, added--recursiveto cosign sign for the because they are multi-arch OCI image index. Without--recursive, cosign signs only the index manifest in a way that is incompatible with how verify resolves the tag against a multi-arch index;--recursiveensures all platform manifests and the index itself are signed.Testing and Verification
Changes were validated by iteratively triggering the workflow_dispatch workflow from the hotfix/release-workflow-perms branch and confirming each previously failing step passed:
Related Issues
https://splunk.atlassian.net/browse/CSPL-4146
PR Checklist