Skip to content

SYN-6770: preserve request redaction#45

Merged
borisvalo merged 8 commits into
v2from
syn-3601-preserve-request-redaction
Jun 26, 2026
Merged

SYN-6770: preserve request redaction#45
borisvalo merged 8 commits into
v2from
syn-3601-preserve-request-redaction

Conversation

@borisvalo

Copy link
Copy Markdown
Contributor

Resolves #SYN-6770


Before the change?

  • Sanitized v2 request details could still expose API-check header-map values such as X-SF-TOKEN.
  • Browser update payloads could not send explicit certificateIds:[] to clear attached client certificates.

After the change?

  • All values under JSON headers maps are redacted in sanitized request details.
  • Existing content, password, and value request-body redaction is preserved.
  • Browser update payloads can distinguish omitted certificateIds from explicit certificateIds:[] without changing the public CertificateIDs []int field type.

Pull request checklist

  • Acceptance Tests have been updated, run (make testacc), and pasted in this PR (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Acceptance Test Output

PASS
coverage: 72.8% of statements
ok  	github.com/splunk/syntheticsclient/v2/syntheticsclientv2	1.431s	coverage: 72.8% of statements

Does this introduce a breaking change?

  • Yes
  • No

@borisvalo borisvalo self-assigned this Jun 24, 2026
Comment thread syntheticsclientv2/common_models.go
@borisvalo borisvalo merged commit 3f90680 into v2 Jun 26, 2026
2 of 4 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants